Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbbHFOwb (ORCPT ); Thu, 6 Aug 2015 10:52:31 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:57799 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbbHFOw3 (ORCPT ); Thu, 6 Aug 2015 10:52:29 -0400 Date: Thu, 6 Aug 2015 10:52:25 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Guenter Roeck , Florian Fainelli , Scott Feldman , Jiri Pirko Subject: Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects Message-ID: <20150806145225.GB20660@ketchup.touchtunes.com> References: <1438839848-505-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1438839848-505-4-git-send-email-vivien.didelot@savoirfairelinux.com> <20150806140432.GC19896@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150806140432.GC19896@lunn.ch> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 37 On 15-08-06 16:04:32, Andrew Lunn wrote: > Hi Vivien > > Thanks for splitting up the big patch. This it is much easier to > review now. > > Is this patch git bisectable? In terms of compilation, yes. > Clearly after this patch, but before all the other patches are in, we > will not be programming the hardware. The call into the driver is > removed here, but the replacement is added later. But is the EOPNOTSUP > enough that the system keeps working, by falling back to software? You're right, it isn't. At this exact patch, issuing the example: bridge fdb add 3c:97:0e:11:30:6e dev swp2 returns "RTNETLINK answers: Operation not supported". > The two driver APIs are very similar, the main difference being the > MAC address. Can you do the refactoring first, and then make the API > change. That means we can test each patch individually, and have > proper git bisectability. That'd be better indeed. I'll integrate the migration from .fdb_{add,del,getnext} to .port_fdb_{add,del,getnext} in this patch, then add the next patches improving FID and ATU management on top of it. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/