Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbbHFPVd (ORCPT ); Thu, 6 Aug 2015 11:21:33 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:39103 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbbHFPVb (ORCPT ); Thu, 6 Aug 2015 11:21:31 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.249.180.47 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <13874cd47adfad36510f0841544b2f8f> X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 1/8] drm: exynos/dp: fix code style To: Joe Perches References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438869866-23028-1-git-send-email-ykk@rock-chips.com> <1438873536.2679.61.camel@perches.com> Cc: Heiko Stuebner , Russell King , Fabio Estevam , Jingoo Han , Inki Dae , djkurtz@google.com, dianders@google.com, Takashi Iwai , Andrzej Hajda , Thierry Reding , Philipp Zabel , David Airlie , Gustavo Padovan , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Kukjin Kim , Ajay Kumar , Joonyoung Shim , Vincent Palatin , Mark Yao , Andy Yan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C37B50.6050706@rock-chips.com> Date: Thu, 6 Aug 2015 23:20:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438873536.2679.61.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 56 Joe, 在 2015/8/6 23:05, Joe Perches 写道: > On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: >> make checkpatch.pl script happy > That should not be the primary reason to submit a patch. > > Making it easier for human code reader to understand > what the code does should be though. Thanks for your reply, but I do think that fix code style and make checkpatch.pl passed is my primary reason to submit this patch. I can't think out more directly words ;( , >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c > [] >> @@ -123,10 +123,11 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp) >> dev_dbg(dp->dev, "EDID data includes a single extension!\n"); >> >> /* Read EDID data */ >> - retval = exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> - EDID_HEADER_PATTERN, >> - EDID_BLOCK_LENGTH, >> - &edid[EDID_HEADER_PATTERN]); >> + retval = >> + exynos_dp_read_bytes_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >> + EDID_HEADER_PATTERN, >> + EDID_BLOCK_LENGTH, >> + &edid[EDID_HEADER_PATTERN]); > This is a relatively uncommon style. > > Because the code uses relatively long variable and > function names as well as longish macro #defines, > prefer to ignore the 80 column limit. Okay, I think it would be better to modify like those: retval = exynos_dp_read_bytes_from_i2c( dp, I2C_EDID_DEVICE_ADDR, EDID_HEADER_PATTERN, EDID_BLOCK_LENGTH, &edid[EDID_HEADER_PATTERN]); Is it okay ? - Yakir > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/