Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932096AbbHFQVh (ORCPT ); Thu, 6 Aug 2015 12:21:37 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:46927 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755196AbbHFQVg convert rfc822-to-8bit (ORCPT ); Thu, 6 Aug 2015 12:21:36 -0400 MIME-Version: 1.0 In-Reply-To: <55C386E9.6060806@citrix.com> References: <55C0F291.7060806@citrix.com> <55C330C7.6050204@citrix.com> <55C386E9.6060806@citrix.com> Date: Thu, 6 Aug 2015 18:21:32 +0200 Message-ID: Subject: Re: [Xen-devel] printk from softirq on xen: hard lockup From: "Jason A. Donenfeld" To: David Vrabel Cc: Ian Campbell , netdev@vger.kernel.org, Paul McKenney , linux-kernel@vger.kernel.org, xen-devel@lists.xen.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 30 In that case, it doesn't compile. arch/x86/xen/apic.c:204:13: error: redefinition of ‘xen_init_apic’ void __init xen_init_apic(void) ^ In file included from arch/x86/xen/apic.c:9:0: arch/x86/xen/xen-ops.h:110:27: note: previous definition of ‘xen_init_apic’ was here static inline void __init xen_init_apic(void) It looks like whoever wrote this explicitly didn't want that APIC driver used on domU: #ifdef CONFIG_XEN_DOM0 void __init xen_init_vga(const struct dom0_vga_console_info *, size_t size); void __init xen_init_apic(void); #else static inline void __init xen_init_vga(const struct dom0_vga_console_info *info, size_t size) { } static inline void __init xen_init_apic(void) { } #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/