Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755516AbbHFRfY (ORCPT ); Thu, 6 Aug 2015 13:35:24 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36306 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755220AbbHFRfO (ORCPT ); Thu, 6 Aug 2015 13:35:14 -0400 From: Adrian Remonda Cc: adrianremonda@gmail.com, gregkh@linuxfoundation.org, christian.gromm@microchip.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCHv6 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings Date: Thu, 6 Aug 2015 19:34:56 +0200 Message-Id: <1438882500-12716-2-git-send-email-adrianremonda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1438882500-12716-1-git-send-email-adrianremonda@gmail.com> References: <1438882500-12716-1-git-send-email-adrianremonda@gmail.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2924 Lines: 87 This is a patch to the mostcore/core.c file. It makes several local functions and structures static to prevent global visibility. v6: fixed warning "line over 80 characters" as pointed out by Sudip Mukherjee Signed-off-by: Adrian Remonda --- drivers/staging/most/mostcore/core.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index f4fea8cf5560..fa9c19b65a5c 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -178,7 +178,7 @@ static void most_free_mbo_coherent(struct mbo *mbo) * flush_channel_fifos - clear the channel fifos * @c: pointer to channel object */ -void flush_channel_fifos(struct most_c_obj *c) +static void flush_channel_fifos(struct most_c_obj *c) { unsigned long flags, hf_flags; struct mbo *mbo, *tmp; @@ -888,7 +888,7 @@ static ssize_t show_add_link(struct most_aim_obj *aim_obj, * Input: "mdev0:ch0@ep_81" * Output: *a -> "mdev0", *b -> "ch0@ep_81", *c == NULL */ -int split_string(char *buf, char **a, char **b, char **c) +static int split_string(char *buf, char **a, char **b, char **c) { *a = strsep(&buf, ":"); if (!*a) @@ -1006,7 +1006,7 @@ static ssize_t store_add_link(struct most_aim_obj *aim_obj, return len; } -struct most_aim_attribute most_aim_attr_add_link = +static struct most_aim_attribute most_aim_attr_add_link = __ATTR(add_link, S_IRUGO | S_IWUSR, show_add_link, store_add_link); static ssize_t show_remove_link(struct most_aim_obj *aim_obj, @@ -1057,7 +1057,7 @@ static ssize_t store_remove_link(struct most_aim_obj *aim_obj, return len; } -struct most_aim_attribute most_aim_attr_remove_link = +static struct most_aim_attribute most_aim_attr_remove_link = __ATTR(remove_link, S_IRUGO | S_IWUSR, show_remove_link, store_remove_link); static struct attribute *most_aim_def_attrs[] = { @@ -1121,14 +1121,14 @@ static void destroy_most_aim_obj(struct most_aim_obj *p) /** * Instantiation of the MOST bus */ -struct bus_type most_bus = { +static struct bus_type most_bus = { .name = "most", }; /** * Instantiation of the core driver */ -struct device_driver mostcore = { +static struct device_driver mostcore = { .name = "mostcore", .bus = &most_bus, }; @@ -1255,7 +1255,8 @@ static void arm_mbo(struct mbo *mbo) * * Returns the number of allocated and enqueued MBOs. */ -int arm_mbo_chain(struct most_c_obj *c, int dir, void (*compl)(struct mbo *)) +static int arm_mbo_chain(struct most_c_obj *c, int dir, + void (*compl)(struct mbo *)) { unsigned int i; int retval; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/