Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755940AbbHFRiw (ORCPT ); Thu, 6 Aug 2015 13:38:52 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:35701 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813AbbHFRiu (ORCPT ); Thu, 6 Aug 2015 13:38:50 -0400 Date: Thu, 6 Aug 2015 13:38:44 -0400 From: Matt Porter To: Peter Meerwald Cc: Linux IIO List , Jonathan Cameron , Linux Kernel Mailing List Subject: Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver Message-ID: <20150806173844.GI23173@beef> References: <1438635410-3757-1-git-send-email-mporter@konsulko.com> <1438635410-3757-3-git-send-email-mporter@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 29 On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: > On Mon, 3 Aug 2015, Matt Porter wrote: ... > > +static int max6675_read(struct max6675_state *st, int *val) > > +{ > > + int ret; > > + > > + ret = spi_read(st->spi, val, 2); > > + if (ret < 0) > > + return ret; > > + > > + /* Temperature is bits 14..3 */ > > + *val = (*val >> 3) & 0xfff; > > what about endianness conversion? > use be16_to_cpu() Apologies, I spoke before engaging the brain on my first reply to this As specified by the SPI subsystem docs, SPI buffers are always stored in native endian order. There is no need for endianness conversion here. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/