From: KY Srinivasan <kys@microsoft.com>
To: Dexuan Cui <decui@microsoft.com>, David Miller <davem@davemloft.net>
CC: "olaf@aepfle.de" <olaf@aepfle.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stephen@networkplumber.org" <stephen@networkplumber.org>,
        "stefanha@redhat.com" <stefanha@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "apw@canonical.com" <apw@canonical.com>,
        "pebolle@tiscali.nl" <pebolle@tiscali.nl>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Subject: RE: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when
 hvsock's callback is running
Thread-Topic: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when
 hvsock's callback is running
Thread-Index: AQHQySYM+NtmNi98EEG2i/XmaPHAV53zCWWAgADGWQCACqMYAIAA2yvw
Date: Thu, 6 Aug 2015 17:50:24 +0000
Message-ID: <SN1PR0301MB166238F1B5F585B79F6C5F94A0740@SN1PR0301MB1662.namprd03.prod.outlook.com>
References: <1438086930-19483-1-git-send-email-decui@microsoft.com>
 <20150729.152809.1531386671239230150.davem@davemloft.net>
 <77fb17eab5474ee7bf34bb1c148b84ea@SIXPR30MB031.064d.mgd.msft.net>
 <1e6203fcf0c645c98944f25425db9406@SIXPR30MB031.064d.mgd.msft.net>
In-Reply-To: <1e6203fcf0c645c98944f25425db9406@SIXPR30MB031.064d.mgd.msft.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2015 17:50:24.5135
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1663
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3835
Lines: 100


> -----Original Message-----
> From: Dexuan Cui
> Sent: Wednesday, August 5, 2015 9:44 PM
> To: David Miller <davem@davemloft.net>; KY Srinivasan
> <kys@microsoft.com>
> Cc: olaf@aepfle.de; gregkh@linuxfoundation.org; jasowang@redhat.com;
> driverdev-devel@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> stephen@networkplumber.org; stefanha@redhat.com;
> netdev@vger.kernel.org; apw@canonical.com; pebolle@tiscali.nl;
> dan.carpenter@oracle.com
> Subject: RE: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when
> hvsock's callback is running
> 
> > -----Original Message-----
> > From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On
> Behalf
> > Of Dexuan Cui
> > Sent: Thursday, July 30, 2015 18:18
> > To: David Miller <davem@davemloft.net>; KY Srinivasan
> <kys@microsoft.com>
> > Cc: olaf@aepfle.de; gregkh@linuxfoundation.org; jasowang@redhat.com;
> > driverdev-devel@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> > stephen@networkplumber.org; stefanha@redhat.com;
> netdev@vger.kernel.org;
> > apw@canonical.com; pebolle@tiscali.nl; dan.carpenter@oracle.com
> > Subject: RE: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt
> when
> > hvsock's callback is running
> >
> > > From: David Miller
> > > Sent: Thursday, July 30, 2015 6:28
> > > > From: Dexuan Cui <decui@microsoft.com>
> > > > Date: Tue, 28 Jul 2015 05:35:30 -0700
> > > >
> > > > In the SMP guest case, when the per-channel callback hvsock_events()
> is
> > > > running on virtual CPU A, if the guest tries to close the connection on
> > > > virtual CPU B: we invoke vmbus_close() -> vmbus_close_internal(),
> > > > then we can have trouble: on B, vmbus_close_internal() will send IPI
> > > > reset_channel_cb() to A, trying to set channel->onchannel_callbackto
> NULL;
> > > > on A, if the IPI handler happens between
> > > > "if (channel->onchannel_callback != NULL)" and invoking
> > > > channel->onchannel_callback, we'll invoke a function pointer of NULL.
> > > >
> > > > This is why the patch is necessary.
> > > >
> > > Sorry, I do not accept that you must use conditional locking and/or
> > > IRQ disabling.
> > >
> > > Boil it down to what is necessary for the least common denominator,
> > > and use that unconditionally.
> >
> > Hi David,
> > Thanks for the comment!
> >
> > I agree with you it's not clean to use conditional IRQ disabling.
> >
> > Here I didn't use unconditionally IRQ disabling because the Hyper-V netvsc
> > and storvsc driver's vmbus event callbacks (i.e. netvsc_channel_cb() and
> > storvsc_on_channel_callback()) may take relatively long time (e.g., netvsc
> can
> > operate at a speed of 10Gb) and I think it's bad to disable IRQ for long time
> > when the callbacks are running in a tasklet context, e.g., the Hyper-V timer
> > can be affected: see vmbus_isr() -> hv_process_timer_expiration().
> >
> > To resolve the race condition between vmbus_close_internal() and
> > process_chn_event() in SMP case, now I propose a new method:
> >
> > we can serialize the 2 paths by adding
> > tasklet_disable(hv_context.event_dpc[channel->target_cpu]) and
> > tasklet_enable(...) in vmbus_close_internal().
> >
> > In this way, we need the least change and we can drop this patch.
> >
> > Please let me know your opinion.
> >
> > -- Dexuan
> 
> Hi David, KY and all,
> 
> May I know your opinion about my idea of adding tasklet_disable/enbable()
> in vmbus_close_internal() and dropping this patch?

Sorry for the delayed response; I think this is a reasonable solution. Send me the patch.

Regards,

K. Y
> 
> Thanks,
> -- Dexuan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/