Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbbHGAEq (ORCPT ); Thu, 6 Aug 2015 20:04:46 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:36483 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbbHGAEp (ORCPT ); Thu, 6 Aug 2015 20:04:45 -0400 Date: Fri, 7 Aug 2015 09:05:20 +0900 From: Sergey Senozhatsky To: Salah Triki Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_* Message-ID: <20150807000520.GA1891@swordfish> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 51 On (08/07/15 00:03), Salah Triki wrote: > This patchset replaces pr_* with dev_*. dev_* attach kernel messages to the right > device. In addition, patchs 1 and 2 add to messages the values of variables that trigger > errors. > Hi, I'd prefer to leave the messages the way they are. Changing anything visible to user space (api, eror codes, error messages, etc.) is a very risky business. You change the format of error messages and it smells like a big NO-NO. 'zram: Cannot initialise lzo compressing backend' --> 'block zram0: Cannot initialise lzo compressing backend' And there are even more dramatic changes: "Cannot change max compression streams\n" --> "Cannot change max compression streams to %d\n" "Can't change algorithm for initialized device\n" --> "Can't change algorithm to %s for initialized device\n" People already can have scripts doing `grep "zram:"` on dmesg or whatever. We cannot change this anymore. This potentially breaks things in user space. So, I NACK the change set. Thanks. Minchan, any opinion? -ss > Salah Triki (3): > zram: Replace pr_info with dev_info in max_comp_streams_store > zram: Replace pr_info with dev_info in comp_algorithm_store > zram: Replace pr_* with dev_* > > drivers/block/zram/zram_drv.c | 34 ++++++++++++++++++++-------------- > 1 file changed, 20 insertions(+), 14 deletions(-) > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/