Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbHGAHH (ORCPT ); Thu, 6 Aug 2015 20:07:07 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:36055 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840AbbHGAHE (ORCPT ); Thu, 6 Aug 2015 20:07:04 -0400 From: Paul Moore To: Steve Grubb , Paul Moore CC: Richard Guy Briggs , , Date: Thu, 06 Aug 2015 20:07:00 -0400 Message-ID: <14f057b6cb8.2852.85c95baa4474aabc7814e68940a78392@paul-moore.com> In-Reply-To: <18689423.1lXpkUPLpg@x2> References: <5456503.IfTzUNfidJ@sifl> <18689423.1lXpkUPLpg@x2> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 AquaMail/1.5.7.29 (build: 21070094) Subject: Re: [PATCH V9 3/3] audit: add audit by children of executable path MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2476 Lines: 62 On August 6, 2015 5:11:50 PM Steve Grubb wrote: > On Thursday, August 06, 2015 04:24:58 PM Paul Moore wrote: > > On Wednesday, August 05, 2015 04:29:38 PM Richard Guy Briggs wrote: > > > This adds the ability to audit the actions of children of a > > > not-yet-running > > > process. > > > > > > > > > > > > This is a split-out of a heavily modified version of a patch originally > > > submitted by Eric Paris with some ideas from Peter Moody. > > > > > > > > > > > > Cc: Peter Moody > > > Cc: Eric Paris > > > Signed-off-by: Richard Guy Briggs > > > --- > > > > > > include/uapi/linux/audit.h | 1 + > > > kernel/auditfilter.c | 5 +++++ > > > kernel/auditsc.c | 11 +++++++++++ > > > 3 files changed, 17 insertions(+), 0 deletions(-) > > > > I'm still not really comfortable with that loop and since there hasn't been > > a really convincing use case I'm going to pass on this patch for right > > now. If someone comes up with a *really* compelling case in the future > > I'll reconsider it. > > Its the same reason strace has a -f option. Sometimes you need to also see > what the children did. For example, maybe you want to audit file access to a > specific directory and several cgi-bin programs can get there. You could write > a rule for apache and be done. Or maybe, you have an app that lets people have > shell access and you need to see files accessed or connections opened. Or maybe > its a control panel application with helper scripts and you need to see > changes that its making. Or maybe you have a program that is at risk of being > compromised and you want to see if someone gets a shell from it. There are a > lot of cases where it could be useful. > > -Steve > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit I guess what I'm saying is that I'm not currently convinced that there is enough value in this to offset the risk I feel the loop presents. I understand the use cases that you are mentioning, the are the same as the last time we discussed this, but I'm going to need something better than that. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/