Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbbHGBRf (ORCPT ); Thu, 6 Aug 2015 21:17:35 -0400 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:52571 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752983AbbHGBRe (ORCPT ); Thu, 6 Aug 2015 21:17:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6261:6691:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13523:13524:14347:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: use73_24af5bb08565b X-Filterd-Recvd-Size: 2048 Message-ID: <1438910251.2322.2.camel@perches.com> Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_* From: Joe Perches To: Sergey Senozhatsky Cc: Salah Triki , minchan@kernel.org, ngupta@vflare.org, linux-kernel@vger.kernel.org Date: Thu, 06 Aug 2015 18:17:31 -0700 In-Reply-To: <20150807000520.GA1891@swordfish> References: <20150807000520.GA1891@swordfish> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 37 On Fri, 2015-08-07 at 09:05 +0900, Sergey Senozhatsky wrote: > On (08/07/15 00:03), Salah Triki wrote: > > This patchset replaces pr_* with dev_*. dev_* attach kernel messages to the right > > device. In addition, patchs 1 and 2 add to messages the values of variables that trigger > > errors. [] > I'd prefer to leave the messages the way they are. Changing anything > visible to user space (api, eror codes, error messages, etc.) is a > very risky business. You change the format of error messages and it > smells like a big NO-NO. > > 'zram: Cannot initialise lzo compressing backend' > --> 'block zram0: Cannot initialise lzo compressing backend' > > > And there are even more dramatic changes: > "Cannot change max compression streams\n" > --> "Cannot change max compression streams to %d\n" > > "Can't change algorithm for initialized device\n" > --> "Can't change algorithm to %s for initialized device\n" > > > People already can have scripts doing `grep "zram:"` on dmesg or > whatever. We cannot change this anymore. That's not true at all. Using grep on dmesg is specifically _not_ guaranteed to remain stable between kernel versions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/