Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbbHGBli (ORCPT ); Thu, 6 Aug 2015 21:41:38 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:33914 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753187AbbHGBlh (ORCPT ); Thu, 6 Aug 2015 21:41:37 -0400 Date: Fri, 7 Aug 2015 10:42:12 +0900 From: Sergey Senozhatsky To: Joe Perches Cc: Sergey Senozhatsky , Salah Triki , minchan@kernel.org, ngupta@vflare.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_* Message-ID: <20150807014212.GB1891@swordfish> References: <20150807000520.GA1891@swordfish> <1438910251.2322.2.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438910251.2322.2.camel@perches.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 43 Hello Joe, On (08/06/15 18:17), Joe Perches wrote: [..] > > "Can't change algorithm for initialized device\n" > > --> "Can't change algorithm to %s for initialized device\n" > > > > > > People already can have scripts doing `grep "zram:"` on dmesg or > > whatever. We cannot change this anymore. > > That's not true at all. > > Using grep on dmesg is specifically _not_ guaranteed > to remain stable between kernel versions. It depends, I guess. People do use grep after all and people don't like when things are getting changed underneath; and we don't want to do this. I think Minchan is with me here. We even didn't add some additional pr_info/pr_err noise recently because we don't want people to depend on that part. http://lkml.iu.edu/hypermail/linux/kernel/1505.3/01759.html Minchan Kim : |I meant if we remove the pr_err in future by some reason, |someone might shout | |"No, it's ABI so if you guys removes it, it will break user interface's |semantic". Maybe he seems to depends on parse on dmesg. |That is not what I want. And I saw some time ago people doing that type of thing. So I'd like to avoid unnecessary pain for zram users even if the messages are not guaranteed to remain stable between kernel releases. Just my opinion. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/