Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754390AbbHGCP3 (ORCPT ); Thu, 6 Aug 2015 22:15:29 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:33723 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373AbbHGCP2 (ORCPT ); Thu, 6 Aug 2015 22:15:28 -0400 Date: Fri, 7 Aug 2015 11:16:03 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Joe Perches , minchan@kernel.org, Salah Triki , ngupta@vflare.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_* Message-ID: <20150807021603.GD1891@swordfish> References: <20150807000520.GA1891@swordfish> <1438910251.2322.2.camel@perches.com> <20150807014212.GB1891@swordfish> <1438912113.2322.7.camel@perches.com> <20150807020356.GC1891@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150807020356.GC1891@swordfish> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 32 On (08/07/15 11:03), Sergey Senozhatsky wrote: > [..] > > because dmesg is not an ABI. > > I absolutely agree, this is debatable and controversial. I saw people > grepping dmesg and they treated error messages just like errno codes or > like additional info to attach to errno. Whether we like or not, but, it > seems, for that cases error message is more or less part of ABI. It's > fine when we change _info message, but touching _warn or _err message > is a bit different thing, *I think*. Let's hear from Minchan. > A side note (not to forget). If Minchan agress that messages are free come and go, then I'd probably like to remove this one meta->table = vzalloc(num_pages * sizeof(*meta->table)); if (!meta->table) { pr_err("Error allocating zram address table\n"); ^^^^^^ goto out_error; } because __vmalloc_node_range() will warn_alloc_failed() anyway. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/