Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754748AbbHGDlg (ORCPT ); Thu, 6 Aug 2015 23:41:36 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36740 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754486AbbHGDld (ORCPT ); Thu, 6 Aug 2015 23:41:33 -0400 Date: Fri, 7 Aug 2015 09:11:28 +0530 From: Viresh Kumar To: Bartlomiej Zolnierkiewicz Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Message-ID: <20150807034128.GE6325@linux> References: <1438868514-8814-1-git-send-email-b.zolnierkie@samsung.com> <1438868514-8814-2-git-send-email-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438868514-8814-2-git-send-email-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3867 Lines: 109 Hi, I would suggest you sending such patches as reply to the earlier threads only, instead of a new chain. This will save your time. For example, you will need to resend other patches unnecessarily if I NAK this patch :) On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote: > Add cpufreq_boost_enabled_generic_attr table and use it in > cpufreq-dt driver instead of cpufreq_generic_attr one when > boost support is enabled. As a result scaling_boost_freqs > sysfs attribute is available when cpufreq-dt driver is > used and boost support is enabled. > > Cc: Viresh Kumar > Cc: Thomas Abraham > Cc: Javier Martinez Canillas > Cc: Krzysztof Kozlowski > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/cpufreq/cpufreq-dt.c | 3 +++ > drivers/cpufreq/freq_table.c | 7 +++++++ > include/linux/cpufreq.h | 1 + > 3 files changed, 11 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index b9259ab..7b091c0 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -182,6 +182,8 @@ try_again: > return ret; > } > > +static struct cpufreq_driver dt_cpufreq_driver; > + > static int cpufreq_init(struct cpufreq_policy *policy) > { > struct cpufreq_frequency_table *freq_table; > @@ -336,6 +338,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) > ret = cpufreq_enable_boost_support(); > if (ret) > goto out_free_cpufreq_table; > + dt_cpufreq_driver.attr = cpufreq_boost_enabled_generic_attr; > } > > policy->cpuinfo.transition_latency = transition_latency; > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c > index a8f1daf..5a00a09 100644 > --- a/drivers/cpufreq/freq_table.c > +++ b/drivers/cpufreq/freq_table.c > @@ -300,6 +300,13 @@ struct freq_attr *cpufreq_generic_attr[] = { > }; > EXPORT_SYMBOL_GPL(cpufreq_generic_attr); > > +struct freq_attr *cpufreq_boost_enabled_generic_attr[] = { > + &cpufreq_freq_attr_scaling_available_freqs, > + &cpufreq_freq_attr_scaling_boost_freqs, > + NULL, > +}; > +EXPORT_SYMBOL_GPL(cpufreq_boost_enabled_generic_attr); This isn't scalable. We can't create a new generic structure every time a entry comes in. Rather we should leave the generic attr for cpufreq-dt and do something like this in the cpufreq-dt driver (And that patch should rather go via cpufreq tree and not ARM SoC).. diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index a5b6a854661f..e229258ad791 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -36,6 +36,12 @@ struct private_data { unsigned int voltage_tolerance; /* in percentage */ }; +static struct freq_attr *cpufreq_dt_attr[] = { + &cpufreq_freq_attr_scaling_available_freqs, + NULL, /* Extra space for boost-attr if required */ + NULL, +}; + static int set_target(struct cpufreq_policy *policy, unsigned int index) { struct dev_pm_opp *opp; @@ -337,6 +343,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) ret = cpufreq_enable_boost_support(); if (ret) goto out_free_cpufreq_table; + cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs; } policy->cpuinfo.transition_latency = transition_latency; @@ -412,7 +419,7 @@ static struct cpufreq_driver dt_cpufreq_driver = { .exit = cpufreq_exit, .ready = cpufreq_ready, .name = "cpufreq-dt", - .attr = cpufreq_generic_attr, + .attr = cpufreq_dt_attr, }; static int dt_cpufreq_probe(struct platform_device *pdev) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/