Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbbHGEKT (ORCPT ); Fri, 7 Aug 2015 00:10:19 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:37787 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbbHGEKQ (ORCPT ); Fri, 7 Aug 2015 00:10:16 -0400 MIME-Version: 1.0 In-Reply-To: <20150807022624.GA11834@dtor-ws> References: <20150807022624.GA11834@dtor-ws> Date: Thu, 6 Aug 2015 21:10:15 -0700 X-Google-Sender-Auth: wHxMecuVr-RvsVVrzYgclGHMJlI Message-ID: Subject: Re: [PATCH] Input: do not emit unneeded EV_SYN when suspending From: Benson Leung To: Dmitry Torokhov Cc: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 21 On Thu, Aug 6, 2015 at 7:26 PM, Dmitry Torokhov wrote: > Do not emit EV_SYN/SYN_REPORT on suspend if there were no keys that are > still pressed as we are suspending the device. It looks like input_dev_release_keys is used in several other places other than input_dev_suspend (reset, disconnect, freeze), so maybe change the commit message to reflect that? Otherwise, LGTM. -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/