Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbbHGEpQ (ORCPT ); Fri, 7 Aug 2015 00:45:16 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36749 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbbHGEpO (ORCPT ); Fri, 7 Aug 2015 00:45:14 -0400 Date: Fri, 7 Aug 2015 10:15:05 +0530 From: Sudip Mukherjee To: Junsu Shin Cc: mchehab@osg.samsung.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org, prabhakar.csengg@gmail.com, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, s.nawrocki@samsung.com, linux-media@vger.kernel.org Subject: Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue. Message-ID: <20150807044505.GB3537@sudip-pc> References: <1438916154-5840-1-git-send-email-jjunes0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438916154-5840-1-git-send-email-jjunes0@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 31 On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote: > This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl. > Signed-off-by: Junsu Shin please do not use whitespace before Signed-off-by: line. > > --- > drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > index 1bbb90c..57cd274 100644 > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, > * @fse: pointer to v4l2_subdev_frame_size_enum structure. > */ > static int > -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, > - struct v4l2_subdev_frame_size_enum *fse) > +ipipe_enum_frame_size(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_size_enum *fse) since you are modifying this line, please fix up the indention also. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/