Date: Fri, 7 Aug 2015 15:37:56 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Salah Triki <salah.triki@acm.org>, ngupta@vflare.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_*
Message-ID: <20150807063756.GH1891@swordfish>
References: <cover.1438899649.git.salah.triki@acm.org>
 <20150807000520.GA1891@swordfish>
 <20150807060559.GA7716@bgram>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150807060559.GA7716@bgram>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2023
Lines: 66

Hello Minchan,

On (08/07/15 15:05), Minchan Kim wrote:
[..]
> > I'd prefer to leave the messages the way they are. Changing anything
> > visible to user space (api, eror codes, error messages, etc.) is a
> > very risky business. You change the format of error messages and it
> > smells like a big NO-NO.
> > 
> > 'zram: Cannot initialise lzo compressing backend'
> > --> 'block zram0: Cannot initialise lzo compressing backend'
> > 
> > 
> > And there are even more dramatic changes:
> > "Cannot change max compression streams\n"
> > --> "Cannot change max compression streams to %d\n"
> > 
> > "Can't change algorithm for initialized device\n"
> > --> "Can't change algorithm to %s for initialized device\n"
> > 
> > 
> > People already can have scripts doing `grep "zram:"` on dmesg or
> > whatever. We cannot change this anymore.
> > 
> > This potentially breaks things in user space. So, I NACK the change
> > set. Thanks.
> > 
> > Minchan, any opinion?
> 
> Note: I didn't read this patchset in detail so I might be wrong.
> 
> When I read description, I couldn't see what's the benefit.
> Please write it out.

we now have errors like
 'zram: Cannot initialise lzo compressing backend'

and they will transform into

 'block zram0: Cannot initialise lzo compressing backend'

note the prefix 'zram:' became 'block zram0:'


and there are two patches (well, at least I quickly spotted only
those) that change messages' text

From:  "Cannot change max compression streams\n"
To: "Cannot change max compression streams to %d\n"

where %d is a supplied max_comp_stream value

From: "Can't change algorithm for initialized device\n"
To: "Can't change algorithm to %s for initialized device\n"

where %s is a supplied compression algorithm name.


as far as I can tell.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/