Message-ID: <1438931526.2322.14.camel@perches.com>
Subject: Re: [PATCH 0/3] zram: Replace pr_* with dev_*
From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Salah Triki <salah.triki@acm.org>,
        ngupta@vflare.org, linux-kernel@vger.kernel.org
Date: Fri, 07 Aug 2015 00:12:06 -0700
In-Reply-To: <20150807065611.GI1891@swordfish>
References: <cover.1438899649.git.salah.triki@acm.org>
	 <20150807000520.GA1891@swordfish> <20150807060559.GA7716@bgram>
	 <20150807063756.GH1891@swordfish> <20150807065611.GI1891@swordfish>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 38

On Fri, 2015-08-07 at 15:56 +0900, Sergey Senozhatsky wrote:
> On (08/07/15 15:37), Sergey Senozhatsky wrote:
> [..]
> where we had clean and nice
> 
> pr_err("Decompression failed!...
> pr_info("Unable to allocate temp memory\n"...
> etc...
> 
> now we have monsters
> 
> dev_err(disk_to_dev(zram->disk), "Decompression failed!...
> dev_info(disk_to_dev(zram->disk), "Unable to allocate temp memory\n"...
> etc.
[]
> other changes are very questionable... for example
>    pr_info("Added device: %s\n", zram->disk->disk_name);
> becomes
>    dev_info(disk_to_dev(zram->disk), "Added device: %s\n", zram->disk->disk_name);
> 
> why? there is no reason to do this!

This seems a reasonable complaint.

One option is to add some macros like

#define zram_err(zram, fmt, ...)				\
	dev_err(disk_to_dev((zram)->disk), fmt, ##__VA_ARGS__)

But the overall utility of the proposed changes is
moderately low to non-existent.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/