Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755024AbbHGH6g (ORCPT ); Fri, 7 Aug 2015 03:58:36 -0400 Received: from mail-bl2on0064.outbound.protection.outlook.com ([65.55.169.64]:58724 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754560AbbHGH6b (ORCPT ); Fri, 7 Aug 2015 03:58:31 -0400 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; arndb.de; dkim=none (message not signed) header.d=none; From: Ley Foon Tan To: Bjorn Helgaas , Russell King , Marc Zyngier CC: Arnd Bergmann , Dinh Nguyen , , , , , , Ley Foon Tan , , Rob Herring Subject: [PATCH v3 3/5] pci: altera: Add Altera PCIe MSI driver Date: Fri, 7 Aug 2015 15:43:00 +0800 Message-ID: <1438933382-2936-4-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1438933382-2936-1-git-send-email-lftan@altera.com> References: <1438933382-2936-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD053;1:H6304MnHMN/5SI+0lCQl5qX2mUWWFJuzXQnVHMQ6SFHIHg6Mi7vPeNh8oqMhUCO45RNKR9dhB2r3OZPVUrT7qIzNPyR2WY6M9hHR/zSEmGxo+r2sSvxkgi+cQd8VTpx7KK5nmeaNvMVuR8o0hZHp3swyeWQBxiq8/EJpaihkw+G4BAuMpi5dRK+oYa+yYGVHpcOFRbPkLidhoX43HuzbGQ0PRjc7Un51EaMVdctDSq0a65i60FU3jfbtvCtsF46tBvLvtNMyDsBUmcjDiAZ5Ki+d3iH84PuTPbBaFhqYrW275J2g/rHZFIJ9cUH9Kgyi X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(189002)(199003)(2950100001)(86362001)(19580395003)(19580405001)(48376002)(6806004)(87936001)(15975445007)(189998001)(68736005)(5003940100001)(106466001)(50466002)(42186005)(62966003)(76176999)(33646002)(5001960100002)(50986999)(105596002)(77156002)(47776003)(5001860100001)(81156007)(4001540100001)(92566002)(50226001)(97736004)(64706001)(5001830100001)(229853001)(46102003)(36756003)(5001770100001)(7099028)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1493;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1493;2:JZx0ztXJ9HJsD8XVnJN5RXNFgbsSZQ2JPjbR/lMQ+rdHC9ojjhbkY1/5Lapw/EYPP5tAuGOuQX/wMBYUghvhJ7VRYSICqmh8j2zAHMWWeQPcR+17UtxC0vaWMpRtG1wa3ok0KBtDpCn3wsUHroh9+wv8X59HSeHjneNHWnRrifg=;3:CnZ+0qlanNYtx1SCgsnljlUnBB4EcJJtSukdRY95nB55gk8i73CDt8yTLTGb/MfwmU2dH8irzNYUuTXoCNr8ECw3VEzpLFld3JR9ALD8ClrALXVIKUQDIOAn6rRXopuk6kEG76S2gYTRjso2WzDKhiX/zjsfzvCYErm827EfLz9MGsKw3TyCIILYWhrgVjvgpHw/rKVWS7N96st9odmKokZiqCISI4+qUKQeSQ/mwx4=;25:oL6cDeFiwA00vWhPiqOgpNxSeRo1uXaYjPauUAL1K8v0oLMJSsxtdc3+rO6VmoNGl0LMGUwJdAGVt1mXxhvyHGMSfZYvGu63jYyUGSvKZFug+Qkeh0vLZeJXOYGxiK3KiRMWF6kofEufqUohKhOz10wGM+vqbG4lv2LmAG6mgKs2ORDl6sKkG+FgSDLmchbDk53MeITA1eCwOWsa1N4o69uteNcpHaBJC7DuVUHnp8xmVRp2ibgueLpdKKXnGf/kEoXoXe/JRjVfeRGnkStWiA==;20:BX7u+h+ZhhsghxIH8zGE+j8xWpmUGIVDTxli4hsd2wqLno2fFzapVc5xF24Xc8PGRiDaNYqvGsG0lFcN8gFcd6d5PEcgzHPSF8JOVm7UTP0ylDZtvqGog6Q+/m1GTkwhXFKToKmyL+jPSAxsevaRcu/ZuISxHwy4koAOOMEt20I= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1493; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR03MB1493;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1493; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1493;4:/oXhot7XHThTsdbBrDwH7J3HnpsNhRG2rVLwI1vOXF4tObkMZuQO+ZSSeicGL+aStVShyyGS5h98J0k3shdNQreCt6JSs1F/X88q01ZuIwxP/kHW2CeKNjfPA7KbfE7Lmy1xaL5+hX1uzcYsVZHfUVFqu9Wp60isGnaOXZ/EOFsrfHOyPGeihDhxU2W1Rgr+xDuXO76LPvzRQXFhwD7FSVhmVSJMSEzLNyeYbnz6uI67KMLH3/0L0xYHhqwLfnoo6cGLlUslFZ2tEckZOrWxHjtZQuQpjPy100evnRG6Tvo= X-Forefront-PRVS: 066153096A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1493;23:A+HvfSgJzSdjZ2J3AToV4iHJvz4SGNGz9n40uvU3M?= =?us-ascii?Q?L+BZfUNqdWZxPjgsCjGqtp0M91vTMfjvrOiQRz/dJosNTHpbxwRf+blgtjiO?= =?us-ascii?Q?eQxhekhNm13K2ZG6M16s555AWdprULd2FH9ZVnFf/a4ybIwvntv2fIRnAgyS?= =?us-ascii?Q?pRLusGXMpQc6TktQyreZufMVj/hVqRQzfJueQCSVNNKWfX0GwtNyj4eUXX4K?= =?us-ascii?Q?OLro/xTz5D5VIdS3s0avhlz8iZXfCzpQ/8nNWHY2fBPaJ8gBVDSSDOsJms8n?= =?us-ascii?Q?ZIuuTNz+KyeioJvlR8l36TXWTnD2ANK8TrYKvdMTmZyxrM84h50eUxWMlXyy?= =?us-ascii?Q?CscP/jZCWKuFMI8xo1M5QoPDUaegZX3hVDaNHH4hjlqcQij324K6iR50u7eP?= =?us-ascii?Q?GGhBbqgKWDBUKiWZrAj/2lOKGm77zCueH2XKAd3BqWPEAkM0SfQKL6xvd5xO?= =?us-ascii?Q?aIbiF+kEAH1JjRGCk7mbTI7tjG9Atx7VmnxcUhvLgl2cnl1tz4pAMcQLlRfR?= =?us-ascii?Q?Vn7clA+Gi+uternd2nubh4ngHjV7WQnCyJT6ITifLoPwgFwLg9w5JBHh5kq+?= =?us-ascii?Q?9ndBYFAadKPYtkDHR+VdcqjR0k+1NmF4kMxoGdaoozg+PqFj4IVMb2vYSw0Q?= =?us-ascii?Q?jQePEatSZcFnSrOvKPigFVt0FKIZHRda9xEfC9UvtiRBI089QRgtn988WLh5?= =?us-ascii?Q?xe/RXcJhjXckXH8ZsMK3lkxjYOD7duIZoUSZPWqTaYCr7RxfdRt8DfFzuA8l?= =?us-ascii?Q?rWWa3J/x60sNTW/htNiM6hsrKqk4WNwZwhyNsu4y3e6jrdjPkrmNZG/OBHkh?= =?us-ascii?Q?zb+xjC1E1yisw12rVOT+LH/xepYXvR5wFc9EzUcGmI3qwFDSX6RUQ5LWJIUY?= =?us-ascii?Q?r5hF2Gs51J064GNAbD/2oqrdBJ8haafIaQdqbjqwaKzOhuBRSzRaQAFGam6X?= =?us-ascii?Q?2fq7MPIR7e6rxjK49s+Eee00OdBFrteDNnkpiTuyEzwNiTfkqzpBc9EN/Jsf?= =?us-ascii?Q?yv3YIkMTF2reiEiEgEiFjfLkiyHaVqtm3DMzGA8XSX6gDfJE5uQtrX23/d2W?= =?us-ascii?Q?jeYr6JJvc9akk/whAwGKK0ta20q?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1493;5:/9ZY9CJFsC1PglYUJGXTw6SGY48HTv0c2qfoKkUBUYxzHJanxum57bnPjgJCqneu/8vMGn6F4O7v8A4/35WYc4znhZuR8ckLXHs9xK0VabkPFGgT2vaRkXWNwTrgHquwUTbcJqK7XUDAam2tpI2GNQ==;24:AUsOXWZAygxRhIKK4yOYIaDOKE4B0lmSZ8uaINEwmlFxNeXtmWCFQVC9J0fxX3ISlyWbtYLLRIMIlBB7FBHxBvBrOj4ei+CbDoIt6x7qelE=;20:Hzj/Wa210G20ZZJFTCm2nsuCFM5xfTrlWrHMcrPu5Hl5npiJ9uAhPdQEs3TX61lVqkvhaQiY6MFoArYB160CIONWvfAeLoGVAPxB6yP9ykRbThGCcNtuYCRqfOH9i3xoa+K9/e5jkHnwnd4w9WRJrksDJh6Bv62udab2OXlqxAU= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2015 07:43:29.5645 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1493 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 10220 Lines: 360 This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c | 309 +++++++++++++++++++++++++++++++++++++ 3 files changed, 318 insertions(+) create mode 100644 drivers/pci/host/pcie-altera-msi.c diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 4b4754a..d28cc6d 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -152,4 +152,12 @@ config PCIE_ALTERA Say Y here if you want to enable PCIe controller support for Altera SoCFPGA family of SoCs. +config PCIE_ALTERA_MSI + bool "Altera PCIe MSI feature" + depends on PCI_MSI + select PCI_MSI_IRQ_DOMAIN + help + Say Y here if you want PCIe MSI support for the Altera SocFPGA SoC. + This MSI driver supports Altera MSI to GIC controller IP. + endmenu diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 6954f76..6c4913d 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -18,3 +18,4 @@ obj-$(CONFIG_PCIE_IPROC) += pcie-iproc.o obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o +obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c new file mode 100644 index 0000000..2d84e62 --- /dev/null +++ b/drivers/pci/host/pcie-altera-msi.c @@ -0,0 +1,309 @@ +/* + * Copyright Altera Corporation (C) 2013-2015. All rights reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see . + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MSI_STATUS 0x0 +#define MSI_ERROR 0x4 +#define MSI_INTMASK 0x8 + +#define MAX_MSI_VECTORS 32 +struct altera_msi { + DECLARE_BITMAP(used, MAX_MSI_VECTORS); + struct mutex lock; /* proctect used variable */ + struct platform_device *pdev; + struct irq_domain *msi_domain; + struct irq_domain *inner_domain; + void __iomem *csr_base; + void __iomem *vector_base; + phys_addr_t vector_phy; + u32 num_of_vectors; + int irq; +}; + +static inline void msi_writel(struct altera_msi *msi, u32 value, u32 reg) +{ + writel_relaxed(value, msi->csr_base + reg); +} + +static inline u32 msi_readl(struct altera_msi *msi, u32 reg) +{ + return readl_relaxed(msi->csr_base + reg); +} + +static void altera_msi_isr(unsigned int irq, struct irq_desc *desc) +{ + struct irq_chip *chip = irq_desc_get_chip(desc); + struct altera_msi *msi; + unsigned long status; + u32 num_of_vectors; + u32 bit; + u32 virq; + + chained_irq_enter(chip, desc); + msi = irq_desc_get_handler_data(desc); + num_of_vectors = msi->num_of_vectors; + + do { + status = msi_readl(msi, MSI_STATUS); + if (!status) + break; + + do { + bit = find_first_bit(&status, num_of_vectors); + /* Dummy read from vector to clear the interrupt */ + readl_relaxed(msi->vector_base + (bit * sizeof(u32))); + + virq = irq_find_mapping(msi->inner_domain, bit); + if (virq && test_bit(bit, msi->used)) + generic_handle_irq(virq); + else + dev_err(&msi->pdev->dev, "unexpected MSI\n"); + + /* Clear the bit from status and repeat without reading + * again status register. */ + __clear_bit(bit, &status); + } while (status); + } while (1); + + chained_irq_exit(chip, desc); +} + +static struct irq_chip altera_msi_irq_chip = { + .name = "Altera PCIe MSI", + .irq_enable = pci_msi_unmask_irq, + .irq_disable = pci_msi_mask_irq, + .irq_mask = pci_msi_mask_irq, + .irq_unmask = pci_msi_unmask_irq, +}; + +static struct msi_domain_info altera_msi_domain_info = { + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_PCI_MSIX), + .chip = &altera_msi_irq_chip, +}; + +static void altera_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) +{ + struct altera_msi *msi = irq_data_get_irq_chip_data(data); + phys_addr_t addr = msi->vector_phy + (data->hwirq * sizeof(u32)); + + msg->address_lo = lower_32_bits(addr); + msg->address_hi = upper_32_bits(addr); + msg->data = data->hwirq; + + dev_dbg(&msi->pdev->dev, "msi#%d address_lo 0x%x address_hi 0x%x\n", + (int)data->hwirq, msg->address_hi, msg->address_lo); +} + +static int altera_msi_set_affinity(struct irq_data *irq_data, + const struct cpumask *mask, bool force) +{ + return -EINVAL; +} + +static struct irq_chip altera_msi_bottom_irq_chip = { + .name = "Altera MSI", + .irq_compose_msi_msg = altera_compose_msi_msg, + .irq_set_affinity = altera_msi_set_affinity, +}; + +static int altera_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, + unsigned int nr_irqs, void *args) +{ + struct altera_msi *msi = domain->host_data; + unsigned long bit; + u32 mask; + + mutex_lock(&msi->lock); + + bit = find_first_zero_bit(msi->used, msi->num_of_vectors); + if (bit >= msi->num_of_vectors) + return -ENOSPC; + + set_bit(bit, msi->used); + + mutex_unlock(&msi->lock); + + irq_domain_set_info(domain, virq, bit, &altera_msi_bottom_irq_chip, + domain->host_data, handle_simple_irq, + NULL, NULL); + set_irq_flags(virq, IRQF_VALID); + + mask = msi_readl(msi, MSI_INTMASK); + mask |= 1 << bit; + msi_writel(msi, mask, MSI_INTMASK); + + return 0; +} + +static void altera_irq_domain_free(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs) +{ + struct irq_data *d = irq_domain_get_irq_data(domain, virq); + struct altera_msi *msi = irq_data_get_irq_chip_data(d); + u32 mask; + + mutex_lock(&msi->lock); + + if (!test_bit(d->hwirq, msi->used)) { + dev_err(&msi->pdev->dev, "trying to free unused MSI#%lu\n", + d->hwirq); + } else { + __clear_bit(d->hwirq, msi->used); + mask = msi_readl(msi, MSI_INTMASK); + mask &= ~(1 << d->hwirq); + msi_writel(msi, mask, MSI_INTMASK); + } + + mutex_unlock(&msi->lock); +} + +static const struct irq_domain_ops msi_domain_ops = { + .alloc = altera_irq_domain_alloc, + .free = altera_irq_domain_free, +}; + +static int altera_allocate_domains(struct altera_msi *msi) +{ + msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, + &msi_domain_ops, msi); + if (!msi->inner_domain) { + dev_err(&msi->pdev->dev, "failed to create IRQ domain\n"); + return -ENOMEM; + } + + msi->msi_domain = pci_msi_create_irq_domain(msi->pdev->dev.of_node, + &altera_msi_domain_info, msi->inner_domain); + if (!msi->msi_domain) { + dev_err(&msi->pdev->dev, "failed to create MSI domain\n"); + irq_domain_remove(msi->inner_domain); + return -ENOMEM; + } + + return 0; +} + +static void altera_free_domains(struct altera_msi *msi) +{ + irq_domain_remove(msi->msi_domain); + irq_domain_remove(msi->inner_domain); +} + +static int altera_msi_remove(struct platform_device *pdev) +{ + struct altera_msi *msi = platform_get_drvdata(pdev); + + msi_writel(msi, 0, MSI_INTMASK); + irq_set_chained_handler(msi->irq, NULL); + irq_set_handler_data(msi->irq, NULL); + + altera_free_domains(msi); + + platform_set_drvdata(pdev, NULL); + return 0; +} + +static int altera_msi_probe(struct platform_device *pdev) +{ + struct altera_msi *msi; + struct device_node *np = pdev->dev.of_node; + struct resource *res; + int ret; + + msi = devm_kzalloc(&pdev->dev, sizeof(struct altera_msi), + GFP_KERNEL); + if (!msi) + return -ENOMEM; + + mutex_init(&msi->lock); + msi->pdev = pdev; + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); + msi->csr_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->csr_base)) { + dev_err(&pdev->dev, "get csr resource failed\n"); + return PTR_ERR(msi->csr_base); + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, + "vector_slave"); + msi->vector_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->vector_base)) { + dev_err(&pdev->dev, "get vector slave resource failed\n"); + return PTR_ERR(msi->vector_base); + } + + msi->vector_phy = res->start; + + if (of_property_read_u32(np, "num-vectors", &msi->num_of_vectors)) { + dev_err(&pdev->dev, "failed to parse the number of vectors\n"); + return -EINVAL; + } + + ret = altera_allocate_domains(msi); + if (ret) + return ret; + + msi->irq = platform_get_irq(pdev, 0); + if (msi->irq <= 0) { + dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq); + ret = -ENODEV; + goto err; + } + + irq_set_chained_handler_and_data(msi->irq, altera_msi_isr, msi); + platform_set_drvdata(pdev, msi); + + return 0; + +err: + altera_msi_remove(pdev); + return ret; +} + +static const struct of_device_id altera_msi_of_match[] = { + { .compatible = "altr,msi-1.0", NULL }, + { }, +}; + +static struct platform_driver altera_msi_driver = { + .driver = { + .name = "altera-msi", + .of_match_table = altera_msi_of_match, + }, + .probe = altera_msi_probe, + .remove = altera_msi_remove, +}; + +static int __init altera_msi_init(void) +{ + return platform_driver_register(&altera_msi_driver); +} + +subsys_initcall(altera_msi_init); + +MODULE_AUTHOR("Ley Foon Tan "); +MODULE_DESCRIPTION("Altera PCIe MSI support"); +MODULE_LICENSE("GPL v2"); -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/