Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbbHGJS5 (ORCPT ); Fri, 7 Aug 2015 05:18:57 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:36321 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbbHGJSx (ORCPT ); Fri, 7 Aug 2015 05:18:53 -0400 Date: Fri, 7 Aug 2015 18:19:28 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Joonsoo Kim , Andrew Morton , Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH] zram: fix possible race when checking idle_strm Message-ID: <20150807091928.GM1891@swordfish> References: <1438934609-16924-1-git-send-email-iamjoonsoo.kim@lge.com> <20150807091457.GL1891@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150807091457.GL1891@swordfish> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 22 On (08/07/15 18:14), Sergey Senozhatsky wrote: [..] > hm... we also can simply forbid downgrading a multi stream backend > to a single stream (in terms of performance it is much slower > than a real single steam anyway). will this do the trick? if we > have more than 1 stream and idle list then there will be more that > one wakeup. and every woken up task will call wakeup once it put > stream. this is unreadable, sorry. should be: "if we have more than 1 stream and _empty_ idle list then there will be more than one wakeup. and every woken up task will call wakeup once it puts stream back to the idle list." -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/