Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbbHGLk3 (ORCPT ); Fri, 7 Aug 2015 07:40:29 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:56012 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752893AbbHGLk2 convert rfc822-to-8bit (ORCPT ); Fri, 7 Aug 2015 07:40:28 -0400 From: Vineet Gupta To: Peter Zijlstra CC: "Theodore Ts'o" , Alexander Viro , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] fs: inode_set_flags() replace opencoded set_mask_bits() Thread-Topic: [PATCH] fs: inode_set_flags() replace opencoded set_mask_bits() Thread-Index: AQHQ0N4HGv7xqj+Rk02ESs+1LqyqFw== Date: Fri, 7 Aug 2015 11:40:23 +0000 Message-ID: References: <1438930504-5644-1-git-send-email-vgupta@synopsys.com> <20150807110955.GH16853@twins.programming.kicks-ass.net> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.191] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 22 On Friday 07 August 2015 04:40 PM, Peter Zijlstra wrote: > On Fri, Aug 07, 2015 at 12:25:04PM +0530, Vineet Gupta wrote: >> > It seems that 5f16f3225b0624 and 00a1a053ebe5, both with same commitlog >> > ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()") >> > introduced the set_mask_bits API, but somehow missed not using it in >> > ext4 in the end >> > >> > Also, set_mask_bits is used in fs quite a bit and we can possibly come up >> > with a generic llsc based implementation (w/o the cmpxchg loop) > May I also suggest changing the return value of set_mask_bits() to old. > > You can compute the new value given old, but you cannot compute the old > value given new, therefore old is the better return value. Also, no > current user seems to use the return value, so changing it is without > risk. Makes sense - will do that early next week ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/