Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753155AbbHGMI1 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Aug 2015 08:08:27 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:32792 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750735AbbHGMIX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Aug 2015 08:08:23 -0400
Date: Fri, 7 Aug 2015 13:07:52 +0100
From: Mark Brown <broonie@kernel.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        linux-arm-kernel@lists.infradead.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
        linux-acpi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Message-ID: <20150807120752.GQ20873@sirena.org.uk>
References: <1438870315-18689-1-git-send-email-tomeu.vizoso@collabora.com>
 <1438870315-18689-6-git-send-email-tomeu.vizoso@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GBlkOKZ0utbUai18"
Content-Disposition: inline
In-Reply-To: <1438870315-18689-6-git-send-email-tomeu.vizoso@collabora.com>
X-Cookie: Please take note:
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 146.198.193.35
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v3 05/18] regulator: core: Reduce critical area in
 _regulator_get
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2071
Lines: 64


--GBlkOKZ0utbUai18
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 06, 2015 at 04:11:42PM +0200, Tomeu Vizoso wrote:

> This backtrace illustrates the situation described above:
>=20
> (regulator_register) from [<c05efe64>]
> (devm_regulator_register+0x48/0x84)

Please don't paste entire backtraces into commit messages, they are
enormous and contain very little useful content - they just obscure
actual information in the commit message.  If you feel there's useful
information in there just include edited highlights with only that.

> +static int _regulator_enable(struct regulator *regulator, bool do_lock)
>  {
> -	int ret;
> +	struct regulator_dev *rdev =3D regulator->rdev;
> +	int ret =3D 0;
> =20
> -	lockdep_assert_held_once(&rdev->mutex);
> +	if (regulator->always_on)
> +		return 0;
> +
> +	if (rdev->supply) {
> +		ret =3D regulator_enable(rdev->supply);
> +		if (ret !=3D 0)
> +			return ret;
> +	}
> +
> +	if (do_lock)
> +		mutex_lock(&rdev->mutex);
> +	else
> +		lockdep_assert_held_once(&rdev->mutex);

Eew.  This do_lock stuff is *not* nice and going to be fragile.  I'm not
a fan, we need something better.

--GBlkOKZ0utbUai18
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVxJ+YAAoJECTWi3JdVIfQK6IH/iukEMdagu+2QgXlAd03ptk8
x81imRrjhtmJCQYoavTErC1M5CbBBkNxfNvUuC70gSvt9IkTeJN1fJD9pJkfjFpR
y9XI93sIIYc5wBlJTlNToxIRakd8Z3530WVgxZ7RV3V5UDmhDRAdv0PTygZmeYcO
X9gyvR5E/dqQwCuDZXZEwYB3hHCy2lA40fdNEQEOvLpX58GL7VSfeaYxla+ZCw/5
bUC9GBYvt8YGl293uKIgsuYAb8RQm0o3ZK5DNKYZq1DmbatvBBAGlnvqYf3YQLZI
q+IE7W0zb+B/5wR2SgSEibx7y1+eKuTIBjKdg6BT/fGCMRA5sOxiE1qI+vYR8fQ=
=l3NK
-----END PGP SIGNATURE-----

--GBlkOKZ0utbUai18--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/