Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbbHGNC2 (ORCPT ); Fri, 7 Aug 2015 09:02:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbbHGNC1 (ORCPT ); Fri, 7 Aug 2015 09:02:27 -0400 Subject: Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type To: Namhyung Kim , Jiri Olsa References: <20150803170804.22235.88475.email-sent-by-dnelson@teal> <20150807105910.GE8624@krava.brq.redhat.com> Cc: a.p.zijlstra@chello.org, Ingo Molnar , Steven Rostedt , Arnaldo Carvalho de Melo , "linux-kernel@vger.kernel.org" , Jiri Olsa From: Dean Nelson Message-ID: <55C4AC61.2050105@redhat.com> Date: Fri, 7 Aug 2015 08:02:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------040808020404080902010901" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8062 Lines: 168 This is a multi-part message in MIME format. --------------040808020404080902010901 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 08/07/2015 07:16 AM, Namhyung Kim wrote: > Hi, > > On Fri, Aug 7, 2015 at 7:59 PM, Jiri Olsa wrote: >> On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: >>> Running the following perf-stat command on an arm64 system produces the >>> following result... >>> >>> [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1 >>> Warning: [kmem:mm_page_alloc] function sizeof not defined >>> Warning: Error: expected type 4 but read 0 >>> Segmentation fault > > Oops, > > >>> [root@aarch64 ~]# >> >> hum, what kernel are you running on? I dont see that warning >> on my system: >> >> [jolsa@krava perf]$ sudo ./perf stat -e kmem:mm_page_alloc -a sleep 1 >> >> Performance counter stats for 'system wide': >> >> 227 kmem:mm_page_alloc >> >> 1.000762466 seconds time elapsed >> >> Cc-ing Namhyung > > Yeah, it seems his kernel has sizeof() somewhere in the event format. > Anyway, it's not good to see a segfault. > > Dean, could you share your event format file? > > $ sudo cat /sys/kernel/debug/tracing/events/kmem/mm_page_alloc/format Sure, I've attached it. See my other email in reply to jirka's question about what kernel I was running on, for some details about where the sizeof operator comes from. > > Thanks, > Namhyung > > >> >>> >>> The second warning message and SIGSEGV stem from the issue expressed in the >>> first warning message, and are the result of ignoring the EVENT_ERROR type >>> returned back through the call chain. >>> >>> Dealing with the first warning message is beyond the scope of this patch. But >>> the second warning is addressed by this patch's first hunk. And the SIGSEGV is >>> eliminated by its second hunk. >>> >>> Signed-off-by: Dean Nelson >>> --- >>> tools/lib/traceevent/event-parse.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c >>> index cc25f05..72e2933 100644 >>> --- a/tools/lib/traceevent/event-parse.c >>> +++ b/tools/lib/traceevent/event-parse.c >>> @@ -1680,6 +1680,9 @@ process_cond(struct event_format *event, struct print_arg *top, char **tok) >>> type = process_arg(event, left, &token); >>> >>> again: >>> + if (type == EVENT_ERROR) >>> + goto out_free; >>> + >>> /* Handle other operations in the arguments */ >>> if (type == EVENT_OP && strcmp(token, ":") != 0) { >>> type = process_op(event, left, &token); >>> @@ -1940,7 +1943,7 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok) >>> >>> type = process_arg_token(event, right, tok, type); >>> >>> - if (right->type == PRINT_OP && >>> + if (type != EVENT_ERROR && right->type == PRINT_OP && >>> get_op_prio(arg->op.op) < get_op_prio(right->op.op)) { >>> struct print_arg tmp; >>> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > --------------040808020404080902010901 Content-Type: text/plain; charset=UTF-8; name="kmem-mm_page_alloc-format" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="kmem-mm_page_alloc-format" bmFtZTogbW1fcGFnZV9hbGxvYwpJRDogMzYwCmZvcm1hdDoKCWZpZWxkOnVuc2lnbmVkIHNo b3J0IGNvbW1vbl90eXBlOwlvZmZzZXQ6MDsJc2l6ZToyOwlzaWduZWQ6MDsKCWZpZWxkOnVu c2lnbmVkIGNoYXIgY29tbW9uX2ZsYWdzOwlvZmZzZXQ6MjsJc2l6ZToxOwlzaWduZWQ6MDsK CWZpZWxkOnVuc2lnbmVkIGNoYXIgY29tbW9uX3ByZWVtcHRfY291bnQ7CW9mZnNldDozOwlz aXplOjE7CXNpZ25lZDowOwoJZmllbGQ6aW50IGNvbW1vbl9waWQ7CW9mZnNldDo0OwlzaXpl OjQ7CXNpZ25lZDoxOwoKCWZpZWxkOnVuc2lnbmVkIGxvbmcgcGZuOwlvZmZzZXQ6ODsJc2l6 ZTo4OwlzaWduZWQ6MDsKCWZpZWxkOnVuc2lnbmVkIGludCBvcmRlcjsJb2Zmc2V0OjE2Owlz aXplOjQ7CXNpZ25lZDowOwoJZmllbGQ6Z2ZwX3QgZ2ZwX2ZsYWdzOwlvZmZzZXQ6MjA7CXNp emU6NDsJc2lnbmVkOjA7CglmaWVsZDppbnQgbWlncmF0ZXR5cGU7CW9mZnNldDoyNDsJc2l6 ZTo0OwlzaWduZWQ6MTsKCnByaW50IGZtdDogInBhZ2U9JXAgcGZuPSVsdSBvcmRlcj0lZCBt aWdyYXRldHlwZT0lZCBnZnBfZmxhZ3M9JXMiLCBSRUMtPnBmbiAhPSAtMVVMID8gKCgoc3Ry dWN0IHBhZ2UgKikoKCgoMHhmZmZmZmZmZmZmZmZmZmZmVUwpIDw8ICgoNDIpIC0gMSkpIC0g KDFVTCA8PCAoKDE2IC0gMykgKiAyICsgMykpIC0gKCgoKCgxVUwgPDwgKCg0MikgLSAxNikp ICogc2l6ZW9mKHN0cnVjdCBwYWdlKSkpICsgKCh0eXBlb2YoKCgxVUwgPDwgKCg0MikgLSAx NikpICogc2l6ZW9mKHN0cnVjdCBwYWdlKSkpKSgoKDFVTCA8PCAoKDE2IC0gMykgKiAyICsg MykpKSkgLSAxKSkgJiB+KCh0eXBlb2YoKCgxVUwgPDwgKCg0MikgLSAxNikpICogc2l6ZW9m KHN0cnVjdCBwYWdlKSkpKSgoKDFVTCA8PCAoKDE2IC0gMykgKiAyICsgMykpKSkgLSAxKSkg LSAweDAwMDEwMDAwKSArIDB4MDAwMTAwMDApKSArIChSRUMtPnBmbikpIDogKCh2b2lkICop MCksIFJFQy0+cGZuICE9IC0xVUwgPyBSRUMtPnBmbiA6IDAsIFJFQy0+b3JkZXIsIFJFQy0+ bWlncmF0ZXR5cGUsIChSRUMtPmdmcF9mbGFncykgPyBfX3ByaW50X2ZsYWdzKFJFQy0+Z2Zw X2ZsYWdzLCAifCIsIHsodW5zaWduZWQgbG9uZykoKCgoKCggZ2ZwX3QpMHgxMHUpIHwgKCgg Z2ZwX3QpMHg0MHUpIHwgKCggZ2ZwX3QpMHg4MHUpIHwgKCggZ2ZwX3QpMHgyMDAwMHUpKSB8 ICgoIGdmcF90KTB4MDJ1KSkgfCAoKCBnZnBfdCkweDA4dSkpIHwgKCggZ2ZwX3QpMHg0MDAw dSkgfCAoKCBnZnBfdCkweDEwMDAwdSkgfCAoKCBnZnBfdCkweDEwMDB1KSB8ICgoIGdmcF90 KTB4MjAwdSkgfCAoKCBnZnBfdCkweDQwMDAwMHUpKSwgIkdGUF9UUkFOU0hVR0UifSwgeyh1 bnNpZ25lZCBsb25nKSgoKCgoIGdmcF90KTB4MTB1KSB8ICgoIGdmcF90KTB4NDB1KSB8ICgo IGdmcF90KTB4ODB1KSB8ICgoIGdmcF90KTB4MjAwMDB1KSkgfCAoKCBnZnBfdCkweDAydSkp IHwgKCggZ2ZwX3QpMHgwOHUpKSwgIkdGUF9ISUdIVVNFUl9NT1ZBQkxFIn0sIHsodW5zaWdu ZWQgbG9uZykoKCgoIGdmcF90KTB4MTB1KSB8ICgoIGdmcF90KTB4NDB1KSB8ICgoIGdmcF90 KTB4ODB1KSB8ICgoIGdmcF90KTB4MjAwMDB1KSkgfCAoKCBnZnBfdCkweDAydSkpLCAiR0ZQ X0hJR0hVU0VSIn0sIHsodW5zaWduZWQgbG9uZykoKCggZ2ZwX3QpMHgxMHUpIHwgKCggZ2Zw X3QpMHg0MHUpIHwgKCggZ2ZwX3QpMHg4MHUpIHwgKCggZ2ZwX3QpMHgyMDAwMHUpKSwgIkdG UF9VU0VSIn0sIHsodW5zaWduZWQgbG9uZykoKCggZ2ZwX3QpMHgxMHUpIHwgKCggZ2ZwX3Qp MHg0MHUpIHwgKCggZ2ZwX3QpMHg4MHUpIHwgKCggZ2ZwX3QpMHg4MDAwMHUpKSwgIkdGUF9U RU1QT1JBUlkifSwgeyh1bnNpZ25lZCBsb25nKSgoKCBnZnBfdCkweDEwdSkgfCAoKCBnZnBf dCkweDQwdSkgfCAoKCBnZnBfdCkweDgwdSkpLCAiR0ZQX0tFUk5FTCJ9LCB7KHVuc2lnbmVk IGxvbmcpKCgoIGdmcF90KTB4MTB1KSB8ICgoIGdmcF90KTB4NDB1KSksICJHRlBfTk9GUyJ9 LCB7KHVuc2lnbmVkIGxvbmcpKCgoIGdmcF90KTB4MjB1KSksICJHRlBfQVRPTUlDIn0sIHso dW5zaWduZWQgbG9uZykoKCggZ2ZwX3QpMHgxMHUpKSwgIkdGUF9OT0lPIn0sIHsodW5zaWdu ZWQgbG9uZykoKCBnZnBfdCkweDIwdSksICJHRlBfSElHSCJ9LCB7KHVuc2lnbmVkIGxvbmcp KCggZ2ZwX3QpMHgxMHUpLCAiR0ZQX1dBSVQifSwgeyh1bnNpZ25lZCBsb25nKSgoIGdmcF90 KTB4NDB1KSwgIkdGUF9JTyJ9LCB7KHVuc2lnbmVkIGxvbmcpKCggZ2ZwX3QpMHgxMDB1KSwg IkdGUF9DT0xEIn0sIHsodW5zaWduZWQgbG9uZykoKCBnZnBfdCkweDIwMHUpLCAiR0ZQX05P V0FSTiJ9LCB7KHVuc2lnbmVkIGxvbmcpKCggZ2ZwX3QpMHg0MDB1KSwgIkdGUF9SRVBFQVQi fSwgeyh1bnNpZ25lZCBsb25nKSgoIGdmcF90KTB4ODAwdSksICJHRlBfTk9GQUlMIn0sIHso dW5zaWduZWQgbG9uZykoKCBnZnBfdCkweDEwMDB1KSwgIkdGUF9OT1JFVFJZIn0sIHsodW5z aWduZWQgbG9uZykoKCBnZnBfdCkweDQwMDB1KSwgIkdGUF9DT01QIn0sIHsodW5zaWduZWQg bG9uZykoKCBnZnBfdCkweDgwMDB1KSwgIkdGUF9aRVJPIn0sIHsodW5zaWduZWQgbG9uZyko KCBnZnBfdCkweDEwMDAwdSksICJHRlBfTk9NRU1BTExPQyJ9LCB7KHVuc2lnbmVkIGxvbmcp KCggZ2ZwX3QpMHgyMDAwdSksICJHRlBfTUVNQUxMT0MifSwgeyh1bnNpZ25lZCBsb25nKSgo IGdmcF90KTB4MjAwMDB1KSwgIkdGUF9IQVJEV0FMTCJ9LCB7KHVuc2lnbmVkIGxvbmcpKCgg Z2ZwX3QpMHg0MDAwMHUpLCAiR0ZQX1RISVNOT0RFIn0sIHsodW5zaWduZWQgbG9uZykoKCBn ZnBfdCkweDgwMDAwdSksICJHRlBfUkVDTEFJTUFCTEUifSwgeyh1bnNpZ25lZCBsb25nKSgo IGdmcF90KTB4MDh1KSwgIkdGUF9NT1ZBQkxFIn0sIHsodW5zaWduZWQgbG9uZykoKCBnZnBf dCkweDIwMDAwMHUpLCAiR0ZQX05PVFJBQ0sifSwgeyh1bnNpZ25lZCBsb25nKSgoIGdmcF90 KTB4NDAwMDAwdSksICJHRlBfTk9fS1NXQVBEIn0sIHsodW5zaWduZWQgbG9uZykoKCBnZnBf dCkweDgwMDAwMHUpLCAiR0ZQX09USEVSX05PREUifSApIDogIkdGUF9OT1dBSVQiCg== --------------040808020404080902010901-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/