Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbbHGNF4 (ORCPT ); Fri, 7 Aug 2015 09:05:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:32932 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbbHGNFz (ORCPT ); Fri, 7 Aug 2015 09:05:55 -0400 Date: Fri, 7 Aug 2015 14:05:40 +0100 From: Mark Brown To: Sjoerd Simons Cc: linux-rockchip@lists.infradead.org, Jaroslav Kysela , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Kumar Gala , Ian Campbell , Takashi Iwai , Liam Girdwood , Pawel Moll , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org Message-ID: <20150807130540.GX20873@sirena.org.uk> References: <1438947854-3743-1-git-send-email-sjoerd.simons@collabora.co.uk> <1438947854-3743-2-git-send-email-sjoerd.simons@collabora.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0X5fYEMtRnv/h11Z" Content-Disposition: inline In-Reply-To: <1438947854-3743-2-git-send-email-sjoerd.simons@collabora.co.uk> X-Cookie: Please take note: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 146.198.193.35 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 40 --0X5fYEMtRnv/h11Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 07, 2015 at 01:44:11PM +0200, Sjoerd Simons wrote: > +- compatible: should be one of the following: > + - "rockchip,rk3066-spdif": for rk3066 > + - "rockchip,rk3188-spdif", "rockchip,rk3066-spdif": for rk3188 > + - "rockchip,rk3288-spdif", "rockchip,rk3066-spdif": for rk3288 The binding claims that we support these three compatibles but the driver only supports rockchip,rk3066-spdif. It's better to list all the compatibles in the binding even if they all boil down to the same thing since it's less error prone when we do start adding device specific code - people are less likely to forget to handle some variant properly. --0X5fYEMtRnv/h11Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVxK0kAAoJECTWi3JdVIfQbGwH/ROkvDXXCTWZyu+uNNKmWVPB 2+aRpnINWRd/i/fwTCTmkmHRSc4caLE875lqvmIPKq63F2HGTtTAEkea975iZfB2 C5tINY7nkTaviS2jiQKLVUu4lS4hO9vKCOsdbQx+jJCNfMxUCxdd1Vv6Ysvkrqb+ jxNATguB1XHPhFPU+e18mZACxyRBx3vUV04vWr4dP6vag1UfeR/7sBxvl1gqHzLg M+5gFV56NPrHwuH6CfwqrujW5OQo/hndyBYeoisdeh0dg/bbAODNSMTk86TrsaYf mIuI5wAg9Bokji25SrrNr4JitMWND0M4ZPQZE5t+3DrcrsKX9dmKSnUF5K53Z7Q= =l4PE -----END PGP SIGNATURE----- --0X5fYEMtRnv/h11Z-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/