Subject: Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode
To: Jingoo Han <jingoohan1@gmail.com>, "'Heiko Stuebner'" <heiko@sntech.de>,
        "'Russell King'" <rmk+kernel@arm.linux.org.uk>,
        "'Fabio Estevam'" <fabio.estevam@freescale.com>,
        "'Inki Dae'" <inki.dae@samsung.com>,
        "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
        dri-devel@lists.freedesktop.org,
        "'Andrzej Hajda'" <a.hajda@samsung.com>,
        "'Gustavo Padovan'" <gustavo.padovan@collabora.co.uk>,
        "'Ajay Kumar'" <ajaykumar.rs@samsung.com>,
        linux-samsung-soc@vger.kernel.org,
        "'Vincent Palatin'" <vpalatin@chromium.org>,
        linux-rockchip@lists.infradead.org, "'Kukjin Kim'" <kgene@kernel.org>,
        "'Thierry Reding'" <treding@nvidia.com>, dianders@google.com,
        linux-arm-kernel@lists.infradead.org,
        "'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
        linux-kernel@vger.kernel.org,
        "'Kyungmin Park'" <kyungmin.park@samsung.com>, djkurtz@google.com,
        "'Andy Yan'" <andy.yan@rock-chips.com>
References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com>
 <1438870041-23130-1-git-send-email-ykk@rock-chips.com>
 <000001d0d052$f44fa3a0$dceeeae0$@com> <55C36F49.6020207@rock-chips.com>
 <20150807112535.GK17734@phenom.ffwll.local>
From: Yakir Yang <ykk@rock-chips.com>
Message-ID: <55C4B012.3010600@rock-chips.com>
Date: Fri, 7 Aug 2015 21:18:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150807112535.GK17734@phenom.ffwll.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2105
Lines: 50

Daniel,

在 2015/8/7 19:25, Daniel Vetter 写道:
> On Thu, Aug 06, 2015 at 10:29:29PM +0800, Yakir Yang wrote:
>> Hi Jingoo,
>>
>> 在 2015/8/6 22:19, Jingoo Han 写道:
>>> On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote:
>>>> In order to move exynos dp code to bridge directory,
>>>> we need to convert driver drm bridge mode first. As
>>>> dp driver already have a ptn3460 bridge, so we need
>>>> to move ptn bridge to the next bridge of dp bridge.
>>>>
>>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>>> ---
>>>>   drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------
>>>>   drivers/gpu/drm/exynos/exynos_dp_core.h |   2 +
>>>>   2 files changed, 126 insertions(+), 72 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>> index a8097a4..aa99e23 100644
>>>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>> @@ -3,6 +3,7 @@
>>>>    *
>>>>    * Copyright (C) 2012 Samsung Electronics Co., Ltd.
>>>>    * Author: Jingoo Han <jg1.han@samsung.com>
>>>> + *         Yakir Yang <ykk@rock-chips.com>
>>> Please don't add this.
>>> You just fixed some parts of this code. I don't find the reason
>>> why you have to be added to author for this file.
>>> If you want the title for an author, please send the patch
>>> for a new IP, instead of modifying the exiting codes.
>> Okay, thanks for your remind ;)
> tbh the author lines are completely irrelevant, git blame/log is the
> authoritative source for that. Copyright is a bit a different matter
> entirely, but in general we seem to be not too good at updating.
Thanks for your good explain  ;)

- Yakir
> Really if that's all you have to comment and no substantial technical
> concerns or questions then just can such a bikeshed mail.
> -Daniel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/