Subject: Re: [PATCH] clk: s5pv210: add missing call to
 samsung_clk_of_add_provider()
To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1411117216-11456-1-git-send-email-m.szyprowski@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Mike Turquette <mturquette@linaro.org>
From: Marek Szyprowski <m.szyprowski@samsung.com>
Message-id: <55C4BC63.6090203@samsung.com>
Date: Fri, 07 Aug 2015 16:10:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-version: 1.0
In-reply-to: <1411117216-11456-1-git-send-email-m.szyprowski@samsung.com>
Content-type: text/plain; charset=utf-8; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1801
Lines: 53

Hello,

On 2014-09-19 11:00, Marek Szyprowski wrote:
> Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
> clk provider only after registering its all clocks", merged to v3.17-rc1)
> modified a way that driver registers registers to core framework. This
> change has not been applied to s5pv210 clocks driver, which has been
> merged in parallel to that commit. This patch adds a missing call to
> samsung_clk_of_add_provider(), so the driver is operational again.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> Hello!
>
> This is an important fix to v3.17-rcX. Without it support for Samsung
> S5PV210 SoCs is not functional.
>
> Mike, could you take it to the fixes branch?

Mike: could you handle this patch? It looks it got missed for a few 
releases...

> Best regards
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
> ---
>   drivers/clk/samsung/clk-s5pv210.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-s5pv210.c b/drivers/clk/samsung/clk-s5pv210.c
> index d270a20..f41b017 100644
> --- a/drivers/clk/samsung/clk-s5pv210.c
> +++ b/drivers/clk/samsung/clk-s5pv210.c
> @@ -828,6 +828,8 @@ static void __init __s5pv210_clk_init(struct device_node *np,
>   
>   	s5pv210_clk_sleep_init();
>   
> +	samsung_clk_of_add_provider(np, ctx);
> +
>   	pr_info("%s clocks: mout_apll = %ld, mout_mpll = %ld\n"
>   		"\tmout_epll = %ld, mout_vpll = %ld\n",
>   		is_s5p6442 ? "S5P6442" : "S5PV210",

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/