From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, sgrubb@redhat.com,
        eparis@redhat.com, peter@hda3.com
Subject: Re: [PATCH V9 2/3] audit: implement audit by executable
Date: Fri, 07 Aug 2015 10:27:30 -0400
Message-ID: <1641279.1Xz85nn9bU@sifl>
Organization: Red Hat
User-Agent: KMail/4.14.10 (Linux/4.1.2-gentoo; KDE/4.14.10; x86_64; ; )
In-Reply-To: <20150807062411.GB12116@madcap2.tricolour.ca>
References: <cover.1438801342.git.rgb@redhat.com> <42326522.RDQEUGoptm@sifl> <20150807062411.GB12116@madcap2.tricolour.ca>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1942
Lines: 43

On Friday, August 07, 2015 02:25:14 AM Richard Guy Briggs wrote:
> On 15/08/06, Paul Moore wrote:
>
> > Merged, although some more minor whitespace tweaks were necessary for
> > checkpatch.  On a related note, if you're not running
> > ./scripts/checlpatch.pl on your patches before sending them out, I would
> > recommend it.  It isn't perfect, but it can catch some silly things that
> > we all do from time to time.
>
> No excuses...  I have been running it pretty regularly and got lazy and
> distracted with patch revisions.  I can't say I agree with the no space
> before closing round parenthesis due to legibility, but will comply.

Okay, glad to hear you run it regularly when submitting patches.

I agree that there are some things I might change about the kernel's style 
choices, but I think it is more important that we remain consistent with the 
kernel as a whole.  I really like tools that enforce things like this, even if 
I don't agree 100% with the results.
 
> > Also, one last thing.  It is pretty late in the -rcX cycle to merge these
> > two patches, but considering that we've been talking about these for a
> > while, I'm reasonably okay merging them.  In the future, if it isn't in
> > audit#next by the time -rc5 is released, it isn't going to make the merge
> > window.
> 
> I've been quite aware of that looming merge window...  This feature has
> been iterating for a while, so there are no big surprises.  I was aiming
> for earlier.  :)

Well, I think it is a little early to say there are no big surprises, we won't 
know that for a few more weeks, but if we make it to -rc3/4 without any 
problems I'll breathe a bit easier ;)

-- 
paul moore
security @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/