Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbbHGPFG (ORCPT ); Fri, 7 Aug 2015 11:05:06 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:34433 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbbHGPFE (ORCPT ); Fri, 7 Aug 2015 11:05:04 -0400 Date: Fri, 7 Aug 2015 17:05:01 +0200 From: Michal Hocko To: Joonsoo Kim Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Shaohua Li , Vlastimil Babka , Eric Dumazet Subject: Re: [PATCH v2] mm/slub: don't wait for high-order page allocation Message-ID: <20150807150501.GJ30785@dhcp22.suse.cz> References: <1438913403-3682-1-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438913403-3682-1-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 32 On Fri 07-08-15 11:10:03, Joonsoo Kim wrote: [...] > diff --git a/mm/slub.c b/mm/slub.c > index 257283f..52b9025 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1364,6 +1364,8 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > * so we fall-back to the minimum order allocation. > */ > alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL; > + if ((alloc_gfp & __GFP_WAIT) && oo_order(oo) > oo_order(s->min)) > + alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_WAIT; Wouldn't it be preferable to "fix" the __GFP_WAIT behavior than spilling __GFP_NOMEMALLOC around the kernel? GFP flags are getting harder and harder to use right and that is a signal we should thing about it and unclutter the current state. > > page = alloc_slab_page(s, alloc_gfp, node, oo); > if (unlikely(!page)) { > -- > 1.9.1 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/