MIME-Version: 1.0
In-Reply-To: <55C4C35A.4070306@zonque.org>
References: <CALCETrW5sdcwM4zoX7BQdf+a2fWgQhd6rPDg8br0FU7Xy-2ZhQ@mail.gmail.com>
 <CALCETrVgot_QD2PC3rP4=ikOir4+A8T550aisLDoNkQMu93UtA@mail.gmail.com>
 <CANq1E4TL4goPTgTDaeQcu5qMwX9MCTN+emaGbSR7Y0ZUGJc_hw@mail.gmail.com>
 <CA+55aFzL93Vqa=a8eckOSReB_L4rX52v_7kcFNRFjkyA_fmd4w@mail.gmail.com>
 <CANq1E4SnYq_pZMWYcafB9GmB_O77tbVLPT0=0d6LGQVpvThTrw@mail.gmail.com>
 <CALCETrWE-oYRq+AzRxxcz03AK0pAzgKJtmxAuNwQu+p5S0msBw@mail.gmail.com>
 <CANq1E4Rek3HXCDU_13OGfRShS7Z0g+fxcTp5C1V3oKC4HgkD_A@mail.gmail.com>
 <CALCETrUaSgdaq4_mr3GG-ekLwGXkQR5MoRLSj9Wu2dTXDYUp1g@mail.gmail.com>
 <CANq1E4SkUWWXuksJnWzXd5KStZx-T6q6+WWTHdrQz_WiMry4Cw@mail.gmail.com>
 <CALCETrXcqOFedk8r-jHK-deRwfum29JHspALE6JUi2gzbo-dhg@mail.gmail.com>
 <55C3A403.8020202@zonque.org> <CALCETrVr04ZdXHLZXLp_Y+m68Db5Mmh_Wnu6prNCfCqgWm0QzA@mail.gmail.com>
 <55C4C35A.4070306@zonque.org>
From: Andy Lutomirski <luto@amacapital.net>
Date: Fri, 7 Aug 2015 08:09:31 -0700
Message-ID: <CALCETrW4YcVAuGZb=kCR_NmTQnMtE+LMGFtPpdszSyHrQp42mA@mail.gmail.com>
Subject: Re: kdbus: to merge or not to merge?
To: Daniel Mack <daniel@zonque.org>
Cc: David Herrmann <dh.herrmann@gmail.com>, Tom Gundersen <teg@jklm.no>,
        "Kalle A. Sandstrom" <ksandstr@iki.fi>,
        Greg KH <gregkh@linuxfoundation.org>, Borislav Petkov <bp@alien8.de>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Havoc Pennington <havoc.pennington@gmail.com>,
        Djalal Harouni <tixxdz@opendz.org>, cee1 <fykcee1@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1234
Lines: 26

On Fri, Aug 7, 2015 at 7:40 AM, Daniel Mack <daniel@zonque.org> wrote:
> On 08/06/2015 08:43 PM, Andy Lutomirski wrote:
>> Nonetheless, it looks like the slice logic (aside: it looks *way* more
>> complicated than necessary -- what's wrong with circular buffers)
>> will, under most (but not all!) workloads, concentrate access to a
>> smallish fraction of the pool.  This is IMO bad, since it means that
>> most of the time most of the pool will remain uncommitted.  If, at
>> some point, something causes the access pattern to change and hit all
>> the pages (even just once), suddenly all of the pools get committed,
>> and your memory usage blows up.
>
> That's a general problem with memory overcommitment, and not specific to
> kdbus. IOW: You'd have the same problem with a similar logic implemented
> in userspace, right?
>

Sure, except that, if it's in userspace and it starts causing
problems, then userspace can fix it without running into kernel ABI
stability issues.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/