Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932493AbbHGQHU (ORCPT ); Fri, 7 Aug 2015 12:07:20 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45551 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639AbbHGQHQ (ORCPT ); Fri, 7 Aug 2015 12:07:16 -0400 Message-ID: <55C4D77A.7010507@oracle.com> Date: Fri, 07 Aug 2015 12:06:18 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , David Vrabel , konrad.wilk@oracle.com CC: kevin.tian@intel.com, jbeulich@suse.com, linux-kernel@vger.kernel.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Stefano Stabellini Subject: Re: [Xen-devel] [PATCH v5 0/6] xen/PMU: PMU support for Xen PV(H) guests References: <1435848816-3323-1-git-send-email-boris.ostrovsky@oracle.com> <55C4D02E.6020108@citrix.com> <55C4D3AC.1060603@citrix.com> In-Reply-To: <55C4D3AC.1060603@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2597 Lines: 65 On 08/07/2015 11:50 AM, Julien Grall wrote: > Hi, > > On 07/08/15 16:35, David Vrabel wrote: >> On 02/07/15 15:53, Boris Ostrovsky wrote: >>> I haven't posted Linux part of PV(H) VPMU support in a while but now >>> that (hopefully) the hypervisor part is getting close to be done I >>> think it's time to post it again. >>> >>> There are very few differences compared to the last version, mostly due >>> to updates in shared structures layouts. Patches 1 and 4 have no changes >>> at all and patch 5 has minor changes due to rebasing so I kept David's >>> Reviewed-by tag. >> This breaks the arm and arm64 builds. >> >> In file included from >> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:23:0: >> /local/davidvr/work/k.org/tip/include/xen/interface/xenpmu.h:91:22: >> error: field ?pmu? has incomplete type >> struct xen_pmu_arch pmu; >> ^ >> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c: In function >> ?pmu_mode_store?: >> /local/davidvr/work/k.org/tip/drivers/xen/sys-hypervisor.c:403:2: error: >> implicit declaration of function ?HYPERVISOR_xenpmu_op? >> [-Werror=implicit-function-declaration] >> ret = HYPERVISOR_xenpmu_op(XENPMU_mode_set, &xp); >> ^ > There is no PMU support for the moment on ARM and this hypercall is only > used for x86. I would introduce a new CONFIG (CONFIG_XEN_PMMU) which is > enabled for x86 and disabled for ARM. CONFIG_XEN_VPMU, but yes. > >> cc1: some warnings being treated as errors >> /local/davidvr/work/k.org/tip/scripts/Makefile.build:258: recipe for >> target 'drivers/xen/sys-hypervisor.o' failed >> make[3]: *** [drivers/xen/sys-hypervisor.o] Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c: In function >> ?xensyms_next_sym?: >> /local/davidvr/work/k.org/tip/drivers/xen/xenfs/xensyms.c:34:2: error: >> implicit declaration of function ?HYPERVISOR_dom0_op? >> [-Werror=implicit-function-declaration] >> ret = HYPERVISOR_dom0_op(&xs->op); >> ^ > DOM0 op doesn't exists for ARM and xensyms is not even plumbed. I would > make sure that XEN_SYMS is not enabled for ARM maybe adding the line > below in the kconfig? > > depends on X86 && XEN_DOM0 && XENFS Yes. Sorry for breakage. I usually build the hypervisor for ARM but clearly didn't do this for Linux. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/