Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946111AbbHGSHP (ORCPT ); Fri, 7 Aug 2015 14:07:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37785 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946037AbbHGSHL (ORCPT ); Fri, 7 Aug 2015 14:07:11 -0400 Date: Fri, 7 Aug 2015 11:07:11 -0700 From: Greg KH To: Tal Shorer Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Message-ID: <20150807180711.GB11113@kroah.com> References: <1438969945-21092-1-git-send-email-tal.shorer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438969945-21092-1-git-send-email-tal.shorer@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 39 On Fri, Aug 07, 2015 at 08:52:25PM +0300, Tal Shorer wrote: > >From the usb 3.1 spec available at http://www.usb.org/developers/docs/ > table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and > GetPortErrorCount as: > > Request bmRequestType bRequest wValue wIndex wLength Data > SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None > GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link > Errors on this port > > Fix these two values to match the spec. > > Signed-off-by: Tal Shorer > --- > include/linux/usb/hcd.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index c9aa779..6a24416 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *); > > /*-------------------------------------------------------------------------*/ > > -/* class requests from USB 3.0 hub spec, table 10-5 */ > -#define SetHubDepth (0x3000 | HUB_SET_DEPTH) > -#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT) > +/* class requests from USB 3.1 hub spec, table 10-7 */ > +#define SetHubDepth (0x2000 | HUB_SET_DEPTH) > +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT) Why did you loose the indentation? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/