Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946047AbbHGS1l (ORCPT ); Fri, 7 Aug 2015 14:27:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33411 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945911AbbHGS1k (ORCPT ); Fri, 7 Aug 2015 14:27:40 -0400 Date: Fri, 7 Aug 2015 19:27:30 +0100 From: Mark Brown To: Salah Triki Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Message-ID: <20150807182730.GL10301@sirena.org.uk> References: <1438968816-5370-1-git-send-email-salah.triki@acm.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vJI8q/aziP9idhqk" Content-Disposition: inline In-Reply-To: <1438968816-5370-1-git-send-email-salah.triki@acm.org> X-Cookie: Biggest security gap -- an open mouth. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: Remove useless check X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 37 --vJI8q/aziP9idhqk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 07, 2015 at 06:33:36PM +0100, Salah Triki wrote: > lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the > return value is useless. No, if you want to do this then you should be fixing the LZO API to remove the returned value - if a value is being returned it's always good practice to pay attention to that, not doing that because the current implementation happens to have some behaviour just makes the code more fragile if someone comes along and changes the implementation. --vJI8q/aziP9idhqk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVxPiRAAoJECTWi3JdVIfQt8sH/iBQv4n4SinHYQFww69gzcmg vcupbkFtJSPPJIFY5x73To1zoBLit2W1GMHvoX8JA+LWaGcam7mAP00V+EuJdq85 c25jvcZslGvuO9yy4IWZs8Cs2CAFUhSp2DGzynkVKFMUw2Yvw3CqR4F5+vUbHmQG 3meIgBbNLyOC2e0kIw9tIy/nAb5gOB8XchikHtvT6GNOKTvvqB4hIgzl3lI2t+6U M4iko/3uNYIpgGGzHrtsilsjj1CHRViJiobNVFtbcjPXidlxWjZwTZ5NJIpXC6Np 81AitlDELaWwT77XzIEIDtzjEG9ttr5uA8d37wVJUjP+37FnUqNatzJniu95XLI= =FcMY -----END PGP SIGNATURE----- --vJI8q/aziP9idhqk-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/