Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946291AbbHGUz7 (ORCPT ); Fri, 7 Aug 2015 16:55:59 -0400 Received: from exsmtp03.microchip.com ([198.175.253.49]:17789 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1945960AbbHGUz6 (ORCPT ); Fri, 7 Aug 2015 16:55:58 -0400 Date: Fri, 7 Aug 2015 22:52:05 +0200 From: Christian Gromm To: AdrianRemonda CC: , , , Sudip Mukherjee Subject: Re: [PATCHv6 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings Message-ID: <20150807225205.2016b536@clu.mchp-main.com> In-Reply-To: <20150807074003.GA13484@debian.home> References: <1438882500-12716-1-git-send-email-adrianremonda@gmail.com> <1438882500-12716-4-git-send-email-adrianremonda@gmail.com> <20150806235728.0863afa5@clu.mchp-main.com> <20150807074003.GA13484@debian.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4627 Lines: 116 On Fri, 7 Aug 2015 09:40:03 +0200 AdrianRemonda wrote: > On Thu, Aug 06, 2015 at 11:57:28PM +0200, Christian Gromm wrote: > > On Thu, 6 Aug 2015 19:34:58 +0200 > > Adrian Remonda wrote: > > > > > This is a patch to the most/hdm-usb/hdm_usb.c file. It > > > makes several local functions and structures static to prevent global > > > visibility. > > > > > > v6: fixed alignment with parameter list of a function. > > > > > > Signed-off-by: Adrian Remonda > > > --- > > > drivers/staging/most/hdm-usb/hdm_usb.c | 16 ++++++++-------- > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c > > > index 514ce3529b7a..305303f2f17c 100644 > > > --- a/drivers/staging/most/hdm-usb/hdm_usb.c > > > +++ b/drivers/staging/most/hdm-usb/hdm_usb.c > > > @@ -290,7 +290,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg) > > > * > > > * Returns 0 on success or error code otherwise. > > > */ > > > -int hdm_poison_channel(struct most_interface *iface, int channel) > > > +static int hdm_poison_channel(struct most_interface *iface, int channel) > > > { > > > struct most_dev *mdev; > > > > > > @@ -328,7 +328,7 @@ int hdm_poison_channel(struct most_interface *iface, int channel) > > > * This inserts the INIC hardware specific padding bytes into a streaming > > > * channel's buffer > > > */ > > > -int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) > > > +static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) > > > { > > > struct most_channel_config *conf = &mdev->conf[channel]; > > > unsigned int j, num_frames, frame_size; > > > @@ -365,7 +365,7 @@ int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) > > > * This takes the INIC hardware specific padding bytes off a streaming > > > * channel's buffer. > > > */ > > > -int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo) > > > +static int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo) > > > { > > > unsigned int j, num_frames, frame_size; > > > struct most_channel_config *const conf = &mdev->conf[channel]; > > > @@ -644,7 +644,7 @@ static void hdm_read_completion(struct urb *urb) > > > * > > > * Context: Could in _some_ cases be interrupt! > > > */ > > > -int hdm_enqueue(struct most_interface *iface, int channel, struct mbo *mbo) > > > +static int hdm_enqueue(struct most_interface *iface, int channel, struct mbo *mbo) > > > { > > > struct most_dev *mdev; > > > struct buf_anchor *anchor; > > > @@ -743,8 +743,8 @@ _error: > > > * @channel: channel ID > > > * @conf: structure that holds the configuration information > > > */ > > > -int hdm_configure_channel(struct most_interface *iface, int channel, > > > - struct most_channel_config *conf) > > > +static int hdm_configure_channel(struct most_interface *iface, int channel, > > > + struct most_channel_config *conf) > > > > Again, please keep the original alignment and start the second line > > of function arguments right beneath the first argument or else this > > function will be different from others. > > > > Thanks, > > Chris > > Hello Christian, > > Whith the patch applied on my tree this looks properly aligned. Could you double check? I did. My client somehow messed it up. Got it fixed... Sorry for the confusion, Chris > > regards, > Adrian > > > > > > { > > > unsigned int num_frames; > > > unsigned int frame_size; > > > @@ -824,7 +824,7 @@ exit: > > > * This triggers the USB vendor requests to read the hardware address and > > > * the current link status of the attached device. > > > */ > > > -int hdm_update_netinfo(struct most_dev *mdev) > > > +static int hdm_update_netinfo(struct most_dev *mdev) > > > { > > > struct device *dev = &mdev->usb_device->dev; > > > int i; > > > @@ -873,7 +873,7 @@ int hdm_update_netinfo(struct most_dev *mdev) > > > * polls for the NI state of the INIC every 2 seconds. > > > * > > > */ > > > -void hdm_request_netinfo(struct most_interface *iface, int channel) > > > +static void hdm_request_netinfo(struct most_interface *iface, int channel) > > > { > > > struct most_dev *mdev; > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/