Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946488AbbHGWlA (ORCPT ); Fri, 7 Aug 2015 18:41:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34633 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946297AbbHGWk6 (ORCPT ); Fri, 7 Aug 2015 18:40:58 -0400 Date: Fri, 7 Aug 2015 15:40:51 -0700 From: Stephen Boyd To: Sylwester Nawrocki Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Boris Brezillon , Chao Xie , Krzysztof Kozlowski , Javier Martinez Canillas , Tomasz Figa , Maxime Ripard , Emilio =?iso-8859-1?Q?L=F3pez?= , Tero Kristo , Geert Uytterhoeven Subject: Re: [PATCH 02/26] clk: Replace __clk_get_num_parents with clk_hw_get_num_parents() Message-ID: <20150807224051.GC16477@codeaurora.org> References: <1438362246-6664-1-git-send-email-sboyd@codeaurora.org> <1438362246-6664-3-git-send-email-sboyd@codeaurora.org> <55C31653.7070000@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C31653.7070000@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1807 Lines: 52 On 08/06, Sylwester Nawrocki wrote: > On 31/07/15 19:03, Stephen Boyd wrote: > > diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c > > index 665cb6794639..8653e555c920 100644 > > --- a/drivers/clk/mmp/clk-mix.c > > +++ b/drivers/clk/mmp/clk-mix.c > > @@ -63,7 +63,7 @@ static unsigned int _get_div(struct mmp_clk_mix *mix, unsigned int val) > > > > static unsigned int _get_mux(struct mmp_clk_mix *mix, unsigned int val) > > { > > - int num_parents = __clk_get_num_parents(mix->hw.clk); > > + int num_parents = clk_hw_get_num_parents(hw); > > Shouldn't this be: > int num_parents = clk_hw_get_num_parents(&mix->hw); Yes thanks! I really gotta fix that script.... Here's the interdiff for this file: diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c index 979e2cfc07c2..403a8b2839c4 100644 --- a/drivers/clk/mmp/clk-mix.c +++ b/drivers/clk/mmp/clk-mix.c @@ -63,7 +63,7 @@ static unsigned int _get_div(struct mmp_clk_mix *mix, unsigned int val) static unsigned int _get_mux(struct mmp_clk_mix *mix, unsigned int val) { - int num_parents = clk_hw_get_num_parents(hw); + int num_parents = clk_hw_get_num_parents(&mix->hw); int i; if (mix->mux_flags & CLK_MUX_INDEX_BIT) @@ -116,7 +116,7 @@ static void _filter_clk_table(struct mmp_clk_mix *mix, struct clk_hw *parent, *hw; unsigned long parent_rate; - hw = &mix->hw + hw = &mix->hw; for (i = 0; i < table_size; i++) { item = &table[i]; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/