Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946558AbbHGXpG (ORCPT ); Fri, 7 Aug 2015 19:45:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36786 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946338AbbHGXpE (ORCPT ); Fri, 7 Aug 2015 19:45:04 -0400 Date: Fri, 7 Aug 2015 16:45:01 -0700 From: Stephen Boyd To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 17/26] clk: rockchip: Convert to clk_hw based provider APIs Message-ID: <20150807234501.GD16477@codeaurora.org> References: <1438362246-6664-1-git-send-email-sboyd@codeaurora.org> <1438362246-6664-18-git-send-email-sboyd@codeaurora.org> <1633764.ZhyQ4HJNBu@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1633764.ZhyQ4HJNBu@diego> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 36 On 08/04, Heiko St?bner wrote: > Am Freitag, 31. Juli 2015, 10:03:57 schrieb Stephen Boyd: > > We're removing struct clk from the clk provider API, so switch > > this code to using the clk_hw based provider APIs. > > > > Cc: Heiko Stuebner > > Signed-off-by: Stephen Boyd > > Looks correct to me and there are no functional changes in here anyway > Reviewed-by: Heiko Stuebner Thanks. There was one bug, but I fixed it ;-) ---8<--- diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c index 198261e001fa..eab430452c52 100644 --- a/drivers/clk/rockchip/clk-pll.c +++ b/drivers/clk/rockchip/clk-pll.c @@ -295,7 +295,7 @@ static void rockchip_rk3066_pll_init(struct clk_hw *hw) if (!parent) { pr_warn("%s: parent of %s not available\n", - __func__, clk_hw_get_parent(hw)); + __func__, clk_hw_get_name(hw)); return; } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/