Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932570AbbHHGWh (ORCPT ); Sat, 8 Aug 2015 02:22:37 -0400 Received: from mail-yk0-f176.google.com ([209.85.160.176]:32794 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754024AbbHHGWf (ORCPT ); Sat, 8 Aug 2015 02:22:35 -0400 MIME-Version: 1.0 In-Reply-To: <20150807175210.GC10003@kroah.com> References: <20150807053451.GC13200@shlinux2> <20150807175210.GC10003@kroah.com> Date: Sat, 8 Aug 2015 14:22:35 +0800 Message-ID: Subject: Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation From: Baolin Wang To: Greg KH Cc: Peter Chen , Felipe Balbi , Mark Brown , LKML , sojka@merica.cz, Alan Stern , andreas@gaisler.com, linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1979 Lines: 50 On 8 August 2015 at 01:52, Greg KH wrote: > On Fri, Aug 07, 2015 at 04:19:40PM +0800, Baolin Wang wrote: >> On 7 August 2015 at 13:34, Peter Chen wrote: >> > On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote: >> >> Currently the Linux kernel does not provide any standard integration of this >> >> feature that integrates the USB subsystem with the system power regulation >> >> provided by PMICs meaning that either vendors must add this in their kernels >> >> or USB gadget devices based on Linux (such as mobile phones) may not behave >> >> as they should. >> >> >> >> Providing a standard framework for doing this in the kernel. >> > >> > Baolin, thanks for introducing a framework for doing it, we do support >> > USB Charger for chipidea driver at internal tree, but it is specific >> > for imx, and still have some problems to upstream due to need to >> > change some common code. >> > >> > One suggestion, would you add your user next time? In that case, we can >> > know better for this framework. >> > >> >> Peter, Thanks for your reviewing and comments. Now I just introduce >> the framework to review for more feedbacks and do not have a useful >> user to use it. I just can show you some example code to show how to >> use it. Thanks. > > Without a real, in-tree user, I can not accept this code. We don't add > "frameworks" for non-existant things, otherwise it will be instantly > ripped out the next kernel release. > > Please come up with at least 2 users, ideally 3, otherwise there's no > real way to know if the framework is sufficient. > OK, I'll try to come up with 2 or 3 users. Thanks. > thanks, > > greg k-h -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/