Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbbHHGtL (ORCPT ); Sat, 8 Aug 2015 02:49:11 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:53478 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbbHHGtJ (ORCPT ); Sat, 8 Aug 2015 02:49:09 -0400 Message-ID: <55C5A657.7060003@ti.com> Date: Sat, 8 Aug 2015 12:18:55 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: NeilBrown CC: Alexander Holler , Greg Kroah-Hartman , , Subject: Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function. References: <20150731194001.933895871@linuxfoundation.org> <20150731194005.016920253@linuxfoundation.org> <55C59952.1000503@ahsoftware.de> In-Reply-To: <55C59952.1000503@ahsoftware.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2338 Lines: 70 On Saturday 08 August 2015 11:23 AM, Alexander Holler wrote: > Hello, > > this patch killed the musb-host functionality on my classic Beagleboard (rev > c4). Symptom was that it there was a message I don't remember and the attached > device didn't enumerate anymore (likely because of missing power, but I'm not > sure). > > A simple revert has fixed it, I haven't looked further into the problem. Neil Brown, how was this tested? -Kishon > > Regards, > > Alexander Holler > > Am 31.07.2015 um 21:39 schrieb Greg Kroah-Hartman: >> 4.1-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: NeilBrown >> >> commit 4724e27114c4a7eceeee07db227a17fcab6f165c upstream. >> >> The USB phy should initialize with power-off, and will be powered on >> by the USB system when a cable connection is detected. >> >> Having this pm_runtime_get_sync() during probe causes the phy to >> *always* be powered on. >> Removing it returns to sensible power management. >> >> Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4 >> Signed-off-by: NeilBrown >> Signed-off-by: Kishon Vijay Abraham I >> Signed-off-by: Greg Kroah-Hartman >> >> --- >> drivers/phy/phy-twl4030-usb.c | 1 - >> 1 file changed, 1 deletion(-) >> >> --- a/drivers/phy/phy-twl4030-usb.c >> +++ b/drivers/phy/phy-twl4030-usb.c >> @@ -711,7 +711,6 @@ static int twl4030_usb_probe(struct plat >> pm_runtime_use_autosuspend(&pdev->dev); >> pm_runtime_set_autosuspend_delay(&pdev->dev, 2000); >> pm_runtime_enable(&pdev->dev); >> - pm_runtime_get_sync(&pdev->dev); >> >> /* Our job is to use irqs and status from the power module >> * to keep the transceiver disabled when nothing's connected. >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/