Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754298AbbHHJCP (ORCPT <rfc822;w@1wt.eu>);
	Sat, 8 Aug 2015 05:02:15 -0400
Received: from mail-pd0-f175.google.com ([209.85.192.175]:36638 "EHLO
	mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754105AbbHHJCM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 8 Aug 2015 05:02:12 -0400
Date: Sat, 8 Aug 2015 01:02:05 -0800
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>,
        Christoph Hellwig <hch@lst.de>, Neil@redhat.com,
        Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@canonical.com>,
        Al@redhat.com, Alasdair Kergon <agk@redhat.com>,
        Lars Ellenberg <drbd-dev@lists.linbit.com>,
        Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
        Christoph Hellwig <hch@infradead.org>, Nitin Gupta <ngupta@vflare.org>,
        Ming Lin <ming.l@ssi.samsung.com>, Oleg Drokin <oleg.drokin@intel.com>,
        Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
        lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
        Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
        drbd-user@lists.linbit.com
Subject: Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request
 handle arbitrarily sized bios
Message-ID: <20150808090205.GA15061@kmo-pixel>
References: <CAF1ivSZbMDgyo_-wFGusSNSZ1fonSMWmNU9aVavGFaQsmEyYmQ@mail.gmail.com>
 <20150731213831.GA16464@redhat.com>
 <1438412290.26596.14.camel@hasee>
 <20150801163356.GA21478@redhat.com>
 <1438581502.26596.24.camel@hasee>
 <20150804113626.GA12682@lst.de>
 <1438754604.29731.31.camel@hasee>
 <20150807073001.GA17485@lst.de>
 <1438990806.24452.8.camel@ssi>
 <55C5C348.1070307@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55C5C348.1070307@suse.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 752
Lines: 14

On Sat, Aug 08, 2015 at 10:52:24AM +0200, Hannes Reinecke wrote:
> Wouldn't it be easier to move both max_write_same_sectors and
> max_discard sectors to 64 bit (ie to type sector_t) and be done with the
> overflow?
> Seems to me this is far too much coding around self-imposed restrictions...

It's bio->bi_iter.bi_size that would have to be increased to 64 bits. Which I
suppose wouldn't actually increase the size of struct bio (when sector_t is 64
bits), since struct bvec_iter has padding right now...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/