Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946729AbbHHJh3 (ORCPT ); Sat, 8 Aug 2015 05:37:29 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:35230 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932660AbbHHJh2 (ORCPT ); Sat, 8 Aug 2015 05:37:28 -0400 MIME-Version: 1.0 In-Reply-To: <1439025863-28481-1-git-send-email-barletz@gmail.com> References: <1439025863-28481-1-git-send-email-barletz@gmail.com> Date: Sat, 8 Aug 2015 11:37:27 +0200 Message-ID: Subject: Re: [PATCH] tty: Fix potentialy used uninitialized variable From: Richard Weinberger To: Tomer Barletz Cc: Greg KH , jslaby@suse.com, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 15 On Sat, Aug 8, 2015 at 11:24 AM, Tomer Barletz wrote: > Initialize size to 0, as it may be used uninitialized in case > read_mem32() fails. Instead of papering over the issue better cleanup read_mem32() such that a failure can be detected. :-) -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/