Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946732AbbHHPfo (ORCPT ); Sat, 8 Aug 2015 11:35:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55898 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964799AbbHHPfm (ORCPT ); Sat, 8 Aug 2015 11:35:42 -0400 Subject: Re: [linux-sunxi] [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi To: public_timo.s@silentcreek.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, maxime.ripard@free-electrons.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> Cc: wens@csie.org From: Hans de Goede Message-ID: <55C621C8.7040302@redhat.com> Date: Sat, 8 Aug 2015 17:35:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2364 Lines: 101 Hi, On 02-08-15 18:18, Timo Sigurdsson wrote: > sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 PMU > driver, so add them to allow for voltage-scaling with cpufreq-dt. > > Signed-off-by: Timo Sigurdsson Thanks for doing this, looks good to me: Acked-by: Hans de Goede Regards, Hans p.s. I've replaced my own patch with this one in my sunxi-wip branch. > --- > Changes since v1 (RFC): > > - Dropped the changes to the cpufreq operating points and renamed the patch > accordingly > - Limited the CPU voltage range so it doesn't exceed the SOC specifications > --- > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 35 ++++++++++++++++++++++++++++---- > 1 file changed, 31 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > index 9f7b472..74382f3 100644 > --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts > @@ -92,6 +92,10 @@ > status = "okay"; > }; > > +&cpu0 { > + cpu-supply = <®_dcdc2>; > +}; > + > &ehci0 { > status = "okay"; > }; > @@ -119,13 +123,9 @@ > status = "okay"; > > axp209: pmic@34 { > - compatible = "x-powers,axp209"; > reg = <0x34>; > interrupt-parent = <&nmi_intc>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > - > - interrupt-controller; > - #interrupt-cells = <1>; > }; > }; > > @@ -182,6 +182,33 @@ > }; > }; > > +#include "axp209.dtsi" > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + regulator-name = "vdd-cpu"; > +}; > + > +®_dcdc3 { > + regulator-always-on; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + regulator-name = "vdd-int-dll"; > +}; > + > +®_ldo1 { > + regulator-name = "vdd-rtc"; > +}; > + > +®_ldo2 { > + regulator-always-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-name = "avcc"; > +}; > + > ®_usb1_vbus { > status = "okay"; > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/