Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946758AbbHHPgJ (ORCPT ); Sat, 8 Aug 2015 11:36:09 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:44988 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946737AbbHHPf7 (ORCPT ); Sat, 8 Aug 2015 11:35:59 -0400 Date: Sat, 8 Aug 2015 16:35:41 +0100 From: Russell King - ARM Linux To: Yakir Yang Cc: linux-rockchip@lists.infradead.org, alsa-devel , dri-devel , linux-kernel@vger.kernel.org, linux-arm-kernel , Doug Anderson , David Airlie , Philipp Zabel , Andy Yan , Daniel Kurtz , Fabio Estevam , Mark Brown , Takashi Iwai , Jaroslav Kysela , Heiko Stuebner , Liam Girdwood , Paul Bolle Subject: Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver Message-ID: <20150808153540.GL7557@n2100.arm.linux.org.uk> References: <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434731295-11060-1-git-send-email-ykk@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 38 On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote: > Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card > driver could connect to this codec through the codec dai name > "dw-hdmi-i2s-audio". I'm applying this patch to my tree with some changes. I haven't seen anyone ack it, nor review it any further. I'm hoping someone can ack this patch with the following changes below - I'll be posting it as part of my dw-hdmi devel updates later today. > + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, > + "dw-dw-audio", dw); DRIVER_NAME, dw); > +MODULE_AUTHOR("Yakir Yang "); > +MODULE_DESCRIPTION("DW dw Audio ASoC Interface"); Fixing this to be "Synopsis DesignWare HDMI I2S ASoC interface". > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); Replacing PLATFORM_MODULE_PREFIX with the "platform:" string. > + if (hdmi_readb(hdmi, HDMI_CONFIG1_ID) & HDMI_CONFIG1_AHB) { > pdevinfo.name = "dw-hdmi-ahb-audio"; Fixing this to be "dw-hdmi-i2s-audio". -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/