Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992585AbbHHRgL (ORCPT ); Sat, 8 Aug 2015 13:36:11 -0400 Received: from mail.kernel.org ([198.145.29.136]:57938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992474AbbHHRgJ (ORCPT ); Sat, 8 Aug 2015 13:36:09 -0400 Date: Sat, 8 Aug 2015 14:35:55 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Kan Liang , Jiri Olsa , Namhyung Kim , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V9 2/3] perf,tools: per-event callgraph support Message-ID: <20150808173555.GC16520@kernel.org> References: <1438890294-33409-1-git-send-email-kan.liang@intel.com> <1438890294-33409-2-git-send-email-kan.liang@intel.com> <20150807153843.GD3325@kernel.org> <20150807154938.GE3325@kernel.org> <20150808164539.GB17040@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150808164539.GB17040@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3307 Lines: 79 Em Sat, Aug 08, 2015 at 06:45:39PM +0200, Jiri Olsa escreveu: > On Fri, Aug 07, 2015 at 12:49:38PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Aug 07, 2015 at 12:38:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Aug 06, 2015 at 03:44:53PM -0400, kan.liang@intel.com escreveu: > > > > From: Kan Liang > > > > Here are some examples and test results. > > > > > > > > 1. Comparing the elapsed time and perf.data size from "kernbench -M -H". > > > > > > > > The test command for FULL callgraph and time support. > > > > "perf record -e > > > > '{cpu/cpu-cycles,period=100000/,cpu/instructions,period=20000/p}' > > > > --call-graph fp --time" > > > > Some other oddity I noticed while testing: > > > > SNIP > > > This is in the 'perf report' TUI, why, for an event with 'callgraph=no', we > > get callchains? How come? > > > > If I try it with the --stdio, well, its there as well: > > > > # Samples: 2K of event 'cpu/instructions,call-graph=no,time=0,period=20000/p' > > # Event count (approx.): 46956518 > > # > > # Children Self Command Shared Object Symbol > > # ........ ........ ............... .......................... .............................................. > > # > > 67.56% 0.00% qemu-system-x86 [unknown] [.] 0xad5e258d4c544155 > > | > > ---0xad5e258d4c544155 > > > > 67.56% 0.00% qemu-system-x86 libc-2.20.so [.] __libc_start_main > > | > > ---__libc_start_main > > 0xad5e258d4c544155 > > > > 67.56% 0.00% qemu-system-x86 perf [.] main > > | > > ---main > > __libc_start_main > > 0xad5e258d4c544155 > > > > 67.56% 0.00% qemu-system-x86 perf [.] run_builtin > > | > > ---run_builtin > > main > > __libc_start_main > > 0xad5e258d4c544155 > > > > Can you take a look? What I have, i.e. the patches from Jiri and Kan > > moving stuff out of the way of the python binding and this patch is at > > the tmp.perf/core branch in my git tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > hum, tried this branch and got proper behaviour for both stdio and TUI, > attaching stdio output > > the record command was: > $ ./perf record -e 'cpu/cpu-cycles,call-graph=fp,time,period=10000/pp,cpu/instructions,call-graph=no,time=0,period=20000/p' ls > > got the events strings from your report output.. what was different in your record command? Was in my message, here it is: # cmdline : /home/acme/bin/perf record -e {cpu/cpu-cycles,call-graph=fp,time,period=10000/pp,cpu/instructions,call-graph=no,time=0,period=20000/p} -a I'll try this again later. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/