Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992780AbbHHUf5 (ORCPT ); Sat, 8 Aug 2015 16:35:57 -0400 Received: from mail.windriver.com ([147.11.1.11]:42032 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992758AbbHHUfw (ORCPT ); Sat, 8 Aug 2015 16:35:52 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Arnd Bergmann , Clemens Ladisch , Greg Kroah-Hartman , Jason Wessel , Subject: [PATCH 0/4] char/misc: make some drivers more explicitly non-modular Date: Sat, 8 Aug 2015 16:35:01 -0400 Message-ID: <1439066105-18412-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2002 Lines: 50 In the previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This allows us to now ensure module code looks modular and non-modular code does not accidentally look modular without suffering build breakage. Here we target code that is, by nature of their Kconfig settings, only available to be built-in, but implicitly presenting itself as being possibly modular by way of using modular headers, macros, and functions. The goal here is to remove that illusion of modularity from these drivers, but in a way that leaves the actual runtime unchanged. In doing so, we remove code that has never been tested and adds no value to the tree. And we advance the process of expecting a level of consistency between the Kconfig of a driver and the code that the driver uses. Build tested on and x86-64, and on ia64 for snsc.c after applying to a baseline of char-misc/char-misc-next Paul. --- Cc: Arnd Bergmann Cc: Clemens Ladisch Cc: Greg Kroah-Hartman Cc: Jason Wessel Cc: kgdb-bugreport@lists.sourceforge.net Paul Gortmaker (4): drivers/char: make efirtc.c driver explicitly non-modular drivers/char: make SGI snsc.c driver explicitly non-modular drivers/char: make hpet.c explicitly non-modular drivers/misc: make kgdbts.c slightly more explicitly non-modular drivers/char/efirtc.c | 13 +++---------- drivers/char/hpet.c | 25 +++---------------------- drivers/char/snsc.c | 5 ++--- drivers/misc/kgdbts.c | 10 +++++----- 4 files changed, 13 insertions(+), 40 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/