Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992965AbbHIAyP (ORCPT ); Sat, 8 Aug 2015 20:54:15 -0400 Received: from mail.windriver.com ([147.11.1.11]:51463 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992898AbbHIAyK (ORCPT ); Sat, 8 Aug 2015 20:54:10 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Greg Kroah-Hartman , Jiri Slaby , Joachim Eastwood , , , Subject: [PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular Date: Sat, 8 Aug 2015 20:51:32 -0400 Message-ID: <1439081497-14986-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2677 Lines: 61 This second set of patches to drivers/tty steps outside of the serial dir, and an improved auditing finds two more serial drivers pretending to be modular that really are not. The reasoning for doing this is the same as the first set[1] of patches and is largely copied below: In the previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This allows us to now ensure module code looks modular and non-modular code does not accidentally look modular without suffering build breakage. Here we target code that is, by nature of their Kconfig settings, only available to be built-in, but implicitly presenting itself as being possibly modular by way of using modular headers, macros, and functions. The goal here is to remove that illusion of modularity from these drivers, but in a way that leaves the actual runtime unchanged. In doing so, we remove code that has never been tested and adds no value to the tree. And we begin the process of expecting a level of consistency between the Kconfig of a driver and the code that the driver uses. Build tested for allyesconfig on x86_64, and ARM for lpc81xx, and powerpc for hvc_console and mpsc, layered onto tty/tty-next as a baseline. Paul. [1] https://lkml.kernel.org/r/1437530538-5078-1-git-send-email-paul.gortmaker@windriver.com -- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Joachim Eastwood Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-serial@vger.kernel.org Paul Gortmaker (5): drivers/tty: make pty.c slightly more explicitly non-modular drivers/tty: make sysrq.c slightly more explicitly non-modular drivers/tty: make hvc_console.c explicitly non-modular drivers/tty: make serial/mpsc.c driver explicitly non-modular drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular drivers/tty/hvc/hvc_console.c | 18 +---------------- drivers/tty/pty.c | 7 +++++-- drivers/tty/serial/8250/8250_lpc18xx.c | 19 ++++-------------- drivers/tty/serial/mpsc.c | 36 +++------------------------------- drivers/tty/sysrq.c | 6 +++++- 5 files changed, 18 insertions(+), 68 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/