Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933018AbbHIMVP (ORCPT ); Sun, 9 Aug 2015 08:21:15 -0400 Received: from hauke-m.de ([5.39.93.123]:43176 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932973AbbHIMVO (ORCPT ); Sun, 9 Aug 2015 08:21:14 -0400 Message-ID: <55C745B7.3040002@hauke-m.de> Date: Sun, 09 Aug 2015 14:21:11 +0200 From: Hauke Mehrtens User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Alban Bedel , linux-mips@linux-mips.org, Ralf Baechle CC: Andrew Bresticker , Qais Yousef , Wolfram Sang , Sergey Ryazanov , Gabor Juhos , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API References: <1429446604-15403-1-git-send-email-albeu@free.fr> <1429446604-15403-6-git-send-email-albeu@free.fr> In-Reply-To: <1429446604-15403-6-git-send-email-albeu@free.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1071 Lines: 27 On 04/19/2015 02:30 PM, Alban Bedel wrote: > Make the code simpler and open the way for device tree clocks. > > Signed-off-by: Alban Bedel > --- > arch/mips/Kconfig | 1 + > arch/mips/ath79/clock.c | 29 ++--------------------------- > 2 files changed, 3 insertions(+), 27 deletions(-) > I think this should be send at least to stable 4.1, because it fixes a linking problem we are seeing in OpenWrt. ath79 does not export clk_set_rate() and clk_round_rate(), but some drivers are using it and they are not using the inline dummy method, because CONFIG_HAVE_CLK is set for ath79. ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined! ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined! ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined! Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/