Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbbHJEoO (ORCPT ); Mon, 10 Aug 2015 00:44:14 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:33874 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbbHJEoN (ORCPT ); Mon, 10 Aug 2015 00:44:13 -0400 Date: Mon, 10 Aug 2015 10:14:04 +0530 From: Sudip Mukherjee To: Swee Hua Law Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux.kernel@junien.fridrick.net, linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org, Julia.Lawall@lip6.fr, elfring@users.sourceforge.net Subject: Re: [PATCH] Fix various coding style problem Message-ID: <20150810044404.GC6528@sudip-pc> References: <1439135314-4020-1-git-send-email-sweehua81@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439135314-4020-1-git-send-email-sweehua81@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 16 On Sun, Aug 09, 2015 at 11:48:34PM +0800, Swee Hua Law wrote: > 1) do not initialise globals to NULL > 2) improve readability of hlist_for_each_entry_safe() > 3) move */ to a separate line > 4) change symbol == NULL to !symbol These were many different changes in a single patch. Please break them into separate patches and send it in a series. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/