Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbbHJGt6 (ORCPT ); Mon, 10 Aug 2015 02:49:58 -0400 Received: from blu004-omc1s5.hotmail.com ([65.55.116.16]:62273 "EHLO BLU004-OMC1S5.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946AbbHJGt4 (ORCPT ); Mon, 10 Aug 2015 02:49:56 -0400 X-TMN: [c5D2EEYiUfXzsGL0RopdrpVXKR5+MJFL] X-Originating-Email: [wanpeng.li@hotmail.com] Message-ID: From: Wanpeng Li To: Andrew Morton CC: Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wanpeng Li Subject: [PATCH 1/2] mm/hwpoison: fix fail to split THP w/ refcount held Date: Mon, 10 Aug 2015 14:32:30 +0800 X-Mailer: git-send-email 1.9.1 X-OriginalArrivalTime: 10 Aug 2015 06:49:54.0774 (UTC) FILETIME=[C3A4EF60:01D0D338] MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 31 THP pages will get a refcount in madvise_hwpoison() w/ MF_COUNT_INCREASED flag, however, the refcount is still held when fail to split THP pages. Fix it by reducing the refcount of THP pages when fail to split THP. Signed-off-by: Wanpeng Li --- mm/memory-failure.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 8077b1c..56b8a71 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1710,6 +1710,8 @@ int soft_offline_page(struct page *page, int flags) if (PageAnon(hpage) && unlikely(split_huge_page(hpage))) { pr_info("soft offline: %#lx: failed to split THP\n", pfn); + if (flags & MF_COUNT_INCREASED) + put_page(page); return -EBUSY; } } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/