Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781AbbHJGiN (ORCPT ); Mon, 10 Aug 2015 02:38:13 -0400 Received: from ozlabs.org ([103.22.144.67]:38117 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbbHJGiM (ORCPT ); Mon, 10 Aug 2015 02:38:12 -0400 In-Reply-To: <1439081497-14986-4-git-send-email-paul.gortmaker@windriver.com> To: Paul Gortmaker , From: Michael Ellerman Cc: Paul Gortmaker , Jiri Slaby , linuxppc-dev@lists.ozlabs.org, Greg Kroah-Hartman Subject: Re: [3/5] drivers/tty: make hvc_console.c explicitly non-modular Message-Id: <20150810063810.477E614027C@ozlabs.org> Date: Mon, 10 Aug 2015 16:38:10 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 31 On Sun, 2015-09-08 at 00:51:35 UTC, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/tty/hvc/Kconfig:config HVC_DRIVER > drivers/tty/hvc/Kconfig: bool > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only, even > though someone bothered to comment that the code was not used. > > Unlike other changes, this driver binds in w/o using module_init, > so we dont have init ordering concerns with this commit. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Paul Gortmaker Seems sane to me, possibly back in the deep dark past it could be a module, but no point keeping the code around if it can't anymore. Acked-by: Michael Ellerman cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/