Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210AbbHJIke (ORCPT ); Mon, 10 Aug 2015 04:40:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:22854 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbbHJIkc (ORCPT ); Mon, 10 Aug 2015 04:40:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,644,1432623600"; d="scan'208";a="781066639" Date: Mon, 10 Aug 2015 11:40:28 +0300 From: Jarkko Sakkinen To: Greg Kroah-Hartman Cc: Jarkko Sakkinen , peterhuewe@gmx.de, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, NeilBrown , Vivien Didelot , Guenter Roeck Subject: Re: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj() Message-ID: <20150810084028.GA11400@intel.com> References: <1435933643-4516-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1435933643-4516-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20150805201123.GB15839@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150805201123.GB15839@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 41 On Wed, Aug 05, 2015 at 01:11:23PM -0700, Greg Kroah-Hartman wrote: > On Fri, Jul 03, 2015 at 05:27:18PM +0300, Jarkko Sakkinen wrote: > > Added a new function sysfs_link_group_to_kobj() that adds a symlink > > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns > > in order to provide a way to remove such symlinks. > > This text doesn't match the function name you exported :( D'oh. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > fs/sysfs/group.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/sysfs.h | 10 ++++++++++ > > 2 files changed, 54 insertions(+) > > > > diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c > > index b400c04..0fb4b6e 100644 > > --- a/fs/sysfs/group.c > > +++ b/fs/sysfs/group.c > > @@ -352,3 +352,47 @@ void sysfs_remove_link_from_group(struct kobject *kobj, const char *group_name, > > } > > } > > EXPORT_SYMBOL_GPL(sysfs_remove_link_from_group); > > + > > +/** > > + * __compat_sysfs_link_entry_to_kobj - add a symlink to a kobject pointing > > Why __compat? https://lkml.org/lkml/2015/7/2/455 Although, should have been '__compat_only'. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/