Date: Mon, 10 Aug 2015 12:41:15 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: gregkh@linuxfoundation.org, lidza.louina@gmail.com, markh@compro.net,
        devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dgnc: Fixed line over 80 characters in
 dgnc_mgmt.c
Message-ID: <20150810094115.GJ5180@mwanda>
References: <20150809124536.GA7077@Karyakshetra>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150809124536.GA7077@Karyakshetra>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1511
Lines: 43

On Sun, Aug 09, 2015 at 06:15:36PM +0530, Bhaktipriya Shridhar wrote:
> Fixed coding style issue "warning line over 80 characters"
> detected by checkpatch.pl in dgnc_mgmt.c

No signed off by.

> ---
>  drivers/staging/dgnc/dgnc_mgmt.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index b13318a..e8fd3da 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  		di.info_bdstate = dgnc_Board[brd]->dpastatus;
>  		di.info_ioport = 0;
>  		di.info_physaddr = (ulong) dgnc_Board[brd]->membase;
> -		di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end;
> +		di.info_physsize = (ulong) dgnc_Board[brd]->membase -
> +			dgnc_Board[brd]->membase_end;

Better to align it like:

		di.info_physsize = (ulong)dgnc_Board[brd]->membase -
					  dgnc_Board[brd]->membase_end;

But even better would be to rename brd to brd_idx and introduce a new
"struct dgnc_board *brd" variable and set:

	brd = dgnc_Board[brd_idx];

Then replace ever reference to "dgnc_Board[brd]" with just "brd".

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/