Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634AbbHJKCZ (ORCPT ); Mon, 10 Aug 2015 06:02:25 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:19181 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373AbbHJKCD (ORCPT ); Mon, 10 Aug 2015 06:02:03 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 10 Aug 2015 02:59:12 -0700 Date: Mon, 10 Aug 2015 12:00:57 +0200 From: Thierry Reding To: Yakir Yang CC: Heiko =?utf-8?Q?St=C3=BCbner?= , Russell King , Fabio Estevam , Jingoo Han , Inki Dae , , , , , Takashi Iwai , Andrzej Hajda , Philipp Zabel , David Airlie , Gustavo Padovan , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Kukjin Kim , Ajay Kumar , Joonyoung Shim , Vincent Palatin , Mark Yao , Andy Yan , , , , , , , Subject: Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver Message-ID: <20150810100055.GB7850@ulmo.nvidia.com> References: <1438943674-18191-1-git-send-email-ykk@rock-chips.com> <1438944380-18897-1-git-send-email-ykk@rock-chips.com> <1730542.s7otqjtiXD@diego> <55C57D7E.6080800@rock-chips.com> MIME-Version: 1.0 In-Reply-To: <55C57D7E.6080800@rock-chips.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) X-Originating-IP: [10.2.69.81] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2749 Lines: 75 --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote: [...] > edp: edp@ff970000 { [...] > hsync-active-high = <0>; > vsync-active-high = <0>; > interlaced = <0>; These look like they should come from the display mode definition (EDID) rather than device tree. > samsung,color-space = <0>; > samsung,dynamic-range = <0>; > samsung,ycbcr-coeff = <0>; I think these should also come from EDID, though I'm not sure if we store this in internal data structures yet. > samsung,color-depth = <1>; This is probably drm_display_info.bpc. > samsung,link-rate = <0x0a>; > samsung,lane-count = <1>; And these should really be derived from values in the DPCD and adjusted (if necessary) during link training. Why would you ever want to hard-code the above? > >>+ dp->clk_24m = devm_clk_get(dev, "clk_dp_24m"); > >Same here, maybe "dp_24m". > Like my previous reply. And actually as those two clocks all have > a common prefix "SCLK" in rk3288 clock tree, I thinkt we can name > them to "sclk_dp" & "sclk_dp_24m", is it okay ? I don't think there's a need for these common prefixes. The names here are identifiers in the context of the IP block, so any SoC-specific prefixes are irrelevant. Also they do appear, in DT and in code, in the context of clocks already, so "sclk_" or "clk_" is completely redundant in these names. Thierry --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyHZUAAoJEN0jrNd/PrOhp5oP/iSeBPiHm7x7u6b+dP6VW1rz 9MLo0o6YJf/HnnwpPdv+2PPOXVfKdTUWoeaHhqvgnW7BkOo2/qFwYOzD4c/4qRUe MNnHYDZfktMNHz40I2D1geNQRVHizI44UCixnRvU+7fFE0AgetyA1wVG8JHf/0Ja xh3y8Jgytvy5qR9RDUlGHhS4NBn40dk0m3NKgoXQ2JD8RFDhyCNGUv12e0mjh3qx uULsAHgCSzYa1uEmE8FuWYFmsdJKXI8NxP5It8WSLCG3qpRf/MMCL+0RSspPer7P AgzzCjYtRqViBUcPCWyblBf3nUdQH+PovitZ9lyPBFbHV4PPaxPn1d9MKDL3jlC6 uMf1wrd7LiV0XLhlvpZOum1M0SqAkpau/2LMyrERSYz0SE88VTSf4mRi6SIvZnLK LK6sIRldrTWCsZiVOumOcI1JfXzqXvxdfZ7YMq/c0tDCd+J/uBhi4E+fFFRjJq4b ht20wyT9q+wDFvspmdwL2AkTC4AerqnuBPCHa3J6uBzoV6TZnuVXHS4YXz6CnyC8 wlROOfyfjIUjLk9I/MYUMdziI2Y9vPdAB6AnbpR0QAKarwSsmji8fGgg3meM2xxo HprjWx/wyD6HRbxTWwWx+IrcU22fubC4gVy0PM5gFmdbMOdDE1CsJ/Z8fBEiGLbh DJd3Ml19dZmrraR7gmkH =hkRn -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/