Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934519AbbHJKUr (ORCPT ); Mon, 10 Aug 2015 06:20:47 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:54377 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517AbbHJKUB (ORCPT ); Mon, 10 Aug 2015 06:20:01 -0400 Subject: Re: [PATCH cgroup/for-4.3 1/3] cgroup: replace error handling in cgroup_init() with WARN_ON()s To: Tejun Heo , Johannes Weiner References: <20150805172012.GO17598@mtj.duckdns.org> CC: , , From: Zefan Li Message-ID: <55C87AB3.1040105@huawei.com> Date: Mon, 10 Aug 2015 18:19:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150805172012.GO17598@mtj.duckdns.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.236] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.55C87AB9.00AF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 02770833963dd1c3066f9c83f07315a9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 19 On 2015/8/6 1:20, Tejun Heo wrote: > The init sequence shouldn't fail short of bugs and even when it does > it's better to continue with the rest of initialization and we were > silently ignoring /proc/cgroups creation failure. > > Drop the explicit error handling and wrap sysfs_create_mount_point(), > register_filesystem() and proc_create() with WARN_ON()s. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Johannes Weiner acked -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/